Skip to content

Commit d238dee

Browse files
seto77claude
andcommitted
Add Directory.Build.props to suppress WFO1000 in CI
The per-project .editorconfig files (Crystallography.Controls, Crystallography.OpenGL) set dotnet_diagnostic.WFO1000.severity = silent, but they are physically owned by the sibling repos reached through NTFS junctions and are NOT tracked by the ReciPro repo (this clone additionally excludes them via .git/info/exclude). So a clean GitHub Actions checkout has no .editorconfig, WFO1000 reverts to its default error severity, and any public property lacking [DesignerSerializationVisibility]/[DefaultValue] breaks the release build (as FormBase.HelpPage just did). Add a tracked root Directory.Build.props with <NoWarn>$(NoWarn);WFO1000</NoWarn> so CI matches local behavior. This is scoped to ReciPro builds (sibling repos resolve their own Directory.Build.props). NoWarn:WFO1000 is already proven effective in CI via ReciPro.csproj. Per-property [DesignerSerializationVisibility] attributes (260322Ch) remain the preferred practice; this is a safety net against a missing attribute breaking CI, not a replacement. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 890d81c commit d238dee

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

Directory.Build.props

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<Project>
2+
3+
<!-- 260530Cl 追加: WFO1000 (DesignerSerializationVisibility 等が未設定のプロパティ) を
4+
ReciPro 配下の全プロジェクトで抑止する。
5+
6+
背景: 各プロジェクト直下の .editorconfig が `dotnet_diagnostic.WFO1000.severity = silent`
7+
を持つが、それらは別リポ (ジャンクション元: Crystallography.Controls / Crystallography.OpenGL 等)
8+
の実体ファイルで、ReciPro リポジトリには未追跡 (このクローンでは .git/info/exclude が .editorconfig を除外)。
9+
そのため GitHub Actions の checkout には .editorconfig が存在せず、WFO1000 が既定の error 重大度に戻り、
10+
属性の付いていない公開プロパティ 1 つ (FormBase.HelpPage) でリリースビルドが失敗した。
11+
追跡されるこのファイルで抑止し、CI とローカルの挙動を一致させる。
12+
13+
なお個別プロパティへの [DesignerSerializationVisibility(Hidden)] / [DefaultValue] 付与方針 (260322Ch)
14+
は引き続き推奨。これは「属性の付け忘れで CI が壊れる」を防ぐ安全網であって、属性付与の代替ではない。 -->
15+
<PropertyGroup>
16+
<NoWarn>$(NoWarn);WFO1000</NoWarn>
17+
</PropertyGroup>
18+
19+
</Project>

0 commit comments

Comments
 (0)