Skip to content

Commit 0abadd1

Browse files
committed
docs(readme): log pvc patch failures
1 parent 321f58d commit 0abadd1

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ Use this runbook to grow the validator and RPC data volumes without recreating t
140140
--values values.yaml
141141
```
142142

143-
3. Expand the in-use PVCs with plain `kubectl` so the StatefulSets keep running while storage grows:
143+
3. Expand the in-use PVCs with plain `kubectl` so the StatefulSets keep running while storage grows. The loop echoes success or failure for each PVC—investigate any errors (insufficient quota, permissions, driver limits) before proceeding:
144144

145145
```bash
146146
# IMPORTANT: Set this to the same value as `network-nodes.persistence.size` from step 1.
@@ -153,8 +153,12 @@ Use this runbook to grow the validator and RPC data volumes without recreating t
153153
-l app.kubernetes.io/instance="${RELEASE}",app.kubernetes.io/component="${component}" \
154154
-o name \
155155
| while read -r pvc; do
156-
kubectl patch -n "${NAMESPACE}" "${pvc}" --type merge \
157-
-p "{\"spec\":{\"resources\":{\"requests\":{\"storage\":\"${NEW_SIZE}\"}}}}"
156+
if kubectl patch -n "${NAMESPACE}" "${pvc}" --type merge \
157+
-p "{\"spec\":{\"resources\":{\"requests\":{\"storage\":\"${NEW_SIZE}\"}}}}"; then
158+
echo "Successfully patched ${pvc}"
159+
else
160+
echo "ERROR: Failed to patch ${pvc}" >&2
161+
fi
158162
done
159163
done
160164
```

README.tpl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ Use this runbook to grow the validator and RPC data volumes without recreating t
140140
--values values.yaml
141141
```
142142

143-
3. Expand the in-use PVCs with plain `kubectl` so the StatefulSets keep running while storage grows:
143+
3. Expand the in-use PVCs with plain `kubectl` so the StatefulSets keep running while storage grows. The loop echoes success or failure for each PVC—investigate any errors (insufficient quota, permissions, driver limits) before proceeding:
144144

145145
```bash
146146
# IMPORTANT: Set this to the same value as `network-nodes.persistence.size` from step 1.
@@ -153,8 +153,12 @@ Use this runbook to grow the validator and RPC data volumes without recreating t
153153
-l app.kubernetes.io/instance="${RELEASE}",app.kubernetes.io/component="${component}" \
154154
-o name \
155155
| while read -r pvc; do
156-
kubectl patch -n "${NAMESPACE}" "${pvc}" --type merge \
157-
-p "{\"spec\":{\"resources\":{\"requests\":{\"storage\":\"${NEW_SIZE}\"}}}}"
156+
if kubectl patch -n "${NAMESPACE}" "${pvc}" --type merge \
157+
-p "{\"spec\":{\"resources\":{\"requests\":{\"storage\":\"${NEW_SIZE}\"}}}}"; then
158+
echo "Successfully patched ${pvc}"
159+
else
160+
echo "ERROR: Failed to patch ${pvc}" >&2
161+
fi
158162
done
159163
done
160164
```

0 commit comments

Comments
 (0)