feat(tests): add validation tests for input parsing and preset values

Author: roderik

src/cli/build-command.test.ts

@@ -5,11 +5,7 @@ import type { BesuAllocAccount } from "../genesis/besu-genesis.service.ts";
 import { ALGORITHM } from "../genesis/besu-genesis.service.ts";
 import type { GeneratedNodeKey } from "../keys/node-key-factory.ts";
 import type { BootstrapDependencies, CliOptions } from "./build-command.ts";
-import {
-  __testing as buildCommandTesting,
-  createCliCommand,
-  runBootstrap,
-} from "./build-command.ts";
+import { createCliCommand, runBootstrap } from "./build-command.ts";
 import type { OutputPayload, OutputType } from "./output.ts";
 import { outputResult as realOutputResult } from "./output.ts";
 
@@ -346,23 +342,4 @@ describe("CLI command bootstrap", () => {
       `Consensus must be one of: ${Object.values(ALGORITHM).join(", ")}.`
     );
   });
-
-  test("parse helpers validate inputs", () => {
-    expect(buildCommandTesting.parsePositiveInteger("5", "Label")).toBe(5);
-    expect(buildCommandTesting.parseNonNegativeInteger("0", "Zero")).toBe(0);
-    expect(buildCommandTesting.parsePositiveBigInt("123", "Big")).toBe("123");
-
-    expect(() =>
-      buildCommandTesting.parsePositiveInteger("0", "Label")
-    ).toThrow("Label must be a positive integer.");
-    expect(() =>
-      buildCommandTesting.parseNonNegativeInteger("-1", "Zero")
-    ).toThrow("Zero must be a non-negative integer.");
-    expect(() => buildCommandTesting.parsePositiveBigInt("-5", "Big")).toThrow(
-      "Big must be a positive integer."
-    );
-    expect(() => buildCommandTesting.parsePositiveBigInt("not", "Big")).toThrow(
-      "Big must be a positive integer."
-    );
-  });
 });

src/cli/build-command.ts

@@ -238,8 +238,3 @@ const createCliCommand = (
 
 export type { BootstrapDependencies, CliOptions };
 export { createCliCommand, runBootstrap };
-export const __testing = {
-  parsePositiveInteger,
-  parseNonNegativeInteger,
-  parsePositiveBigInt,
-};

src/cli/genesis-prompts.test.ts

@@ -8,7 +8,6 @@ import {
   type BesuGenesisService,
 } from "../genesis/besu-genesis.service.ts";
 import {
-  __testing as genesisTesting,
   type HexAddress,
   type PromptOverrides,
   promptForGenesisConfig,
@@ -24,6 +23,9 @@ const SECOND_CHAIN_ID = 1;
 const SECOND_BLOCK_TIME = 2;
 const EVM_STACK_SIZE = 4096;
 const CONTRACT_SIZE_LIMIT = 10_000;
+const NEGATIVE_PRESET_INT = -1;
+const NEGATIVE_BIG_VALUE = "-1";
+const NON_NUMERIC_BIG_VALUE = "not-a-number";
 
 const withCancel = <T>(value: T) => {
   const promise = Promise.resolve(value) as Promise<T> & { cancel: () => void };
@@ -250,12 +252,12 @@ describe("promptForGenesisConfig", () => {
         faucetAddress: faucet,
         preset: {
           algorithm: ALGORITHM.IBFTv2,
-          chainId: -1,
-          secondsPerBlock: -2,
-          gasLimit: "-5",
-          gasPrice: -1,
-          evmStackSize: -3,
-          contractSizeLimit: -4,
+          chainId: NEGATIVE_PRESET_INT,
+          secondsPerBlock: NEGATIVE_PRESET_INT,
+          gasLimit: NEGATIVE_BIG_VALUE,
+          gasPrice: NEGATIVE_PRESET_INT,
+          evmStackSize: NEGATIVE_PRESET_INT,
+          contractSizeLimit: NEGATIVE_PRESET_INT,
         },
         validatorAddresses: validators,
       })
@@ -273,7 +275,7 @@ describe("promptForGenesisConfig", () => {
           chainId: 1,
           secondsPerBlock: 1,
           gasLimit: "1000",
-          gasPrice: -1,
+          gasPrice: NEGATIVE_PRESET_INT,
           evmStackSize: 2048,
           contractSizeLimit: 100_000,
         },
@@ -312,7 +314,7 @@ describe("promptForGenesisConfig", () => {
           algorithm: ALGORITHM.IBFTv2,
           chainId: 1,
           secondsPerBlock: 1,
-          gasLimit: "not-a-number",
+          gasLimit: NON_NUMERIC_BIG_VALUE,
           gasPrice: 0,
           evmStackSize: 2048,
           contractSizeLimit: 100_000,
@@ -321,23 +323,4 @@ describe("promptForGenesisConfig", () => {
       })
     ).rejects.toThrow("Gas limit must be a positive integer.");
   });
-
-  test("ensure helpers validate preset values", () => {
-    expect(genesisTesting.ensurePositiveInteger(5, "Value")).toBe(5);
-    expect(genesisTesting.ensureNonNegativeInteger(0, "Zero")).toBe(0);
-    expect(genesisTesting.ensurePositiveBigIntString("100", "Big")).toBe("100");
-
-    expect(() => genesisTesting.ensurePositiveInteger(0, "Value")).toThrow(
-      "Value must be a positive integer."
-    );
-    expect(() => genesisTesting.ensureNonNegativeInteger(-1, "Zero")).toThrow(
-      "Zero must be a non-negative integer."
-    );
-    expect(() => genesisTesting.ensurePositiveBigIntString("0", "Big")).toThrow(
-      "Big must be a positive integer."
-    );
-    expect(() =>
-      genesisTesting.ensurePositiveBigIntString("bad", "Big")
-    ).toThrow("Big must be a positive integer.");
-  });
 });

src/cli/genesis-prompts.ts

@@ -239,8 +239,3 @@ export type {
   GenesisPromptPreset,
 };
 export { promptForGenesisConfig };
-export const __testing = {
-  ensurePositiveInteger,
-  ensureNonNegativeInteger,
-  ensurePositiveBigIntString,
-};