fix(bootstrap): skip static nodes generation when keys artifact is ex… (#111)

…cluded

Static nodes are derived from validator keys, so they should only be
generated when the 'keys' artifact is included in --artifacts filter.
This prevents unwanted ConfigMap conflicts when selectively generating
artifacts.

- Skip static nodes in screen output when keys are not generated
- Skip static nodes.json file output when keys are not generated
- Skip static-nodes ConfigMap in kubernetes output when keys are not
generated
- Update tests to verify static nodes respect the keys artifact filter

When --artifacts is not specified, all artifacts default to enabled
(including keys), so static nodes continue to be generated in that case.

## Summary by Sourcery

Skip static nodes generation when the keys artifact is excluded to avoid
unwanted ConfigMap conflicts while preserving default behavior when no
filter is specified

Enhancements:
- Omit static nodes from screen output, file output, and Kubernetes
ConfigMaps if the keys artifact is disabled

Tests:
- Add tests to verify static nodes are only included when the keys
filter is enabled and excluded otherwise

Author: insider89

src/cli/commands/bootstrap/bootstrap.output.ts

@@ -165,8 +165,8 @@ const outputToScreen = (payload: OutputPayload): void => {
   if (artifactFilter.keys) {
     printGroup("Validator Nodes", payload.validators);
     printFaucet(payload.faucet);
+    printStaticNodes(payload.staticNodes);
   }
-  printStaticNodes(payload.staticNodes);
 };
 
 const formatTimestampForDirectory = (date: Date): string => {
@@ -246,11 +246,13 @@ const outputToFile = async (payload: OutputPayload): Promise<string> => {
     );
   }
 
-  fileEntries.push({
-    path: join(directory, `${artifactNames.staticNodesConfigMapName}.json`),
-    description: `${artifactNames.staticNodesConfigMapName}.json`,
-    contents: `${JSON.stringify(payload.staticNodes, null, 2)}\n`,
-  });
+  if (artifactFilter.keys) {
+    fileEntries.push({
+      path: join(directory, `${artifactNames.staticNodesConfigMapName}.json`),
+      description: `${artifactNames.staticNodesConfigMapName}.json`,
+      contents: `${JSON.stringify(payload.staticNodes, null, 2)}\n`,
+    });
+  }
 
   if (artifactFilter.subgraph && payload.subgraphHash) {
     fileEntries.push({
@@ -303,6 +305,11 @@ const outputToKubernetes = async (payload: OutputPayload): Promise<void> => {
     configMapSpecs.push(
       ...createFaucetConfigSpecs(payload.faucet, artifactNames.faucetPrefix)
     );
+    configMapSpecs.push({
+      name: artifactNames.staticNodesConfigMapName,
+      key: "static-nodes.json",
+      value: `${JSON.stringify(payload.staticNodes, null, 2)}\n`,
+    });
   }
 
   if (artifactFilter.genesis) {
@@ -315,12 +322,6 @@ const outputToKubernetes = async (payload: OutputPayload): Promise<void> => {
     });
   }
 
-  configMapSpecs.push({
-    name: artifactNames.staticNodesConfigMapName,
-    key: "static-nodes.json",
-    value: `${JSON.stringify(payload.staticNodes, null, 2)}\n`,
-  });
-
   if (artifactFilter.abis) {
     configMapSpecs.push(...createAbiConfigSpecs(payload.abiArtifacts));
   }

src/cli/commands/bootstrap/bootstrap.selective-artifacts.test.ts

@@ -130,7 +130,7 @@ describe("Selective artifact generation - screen output", () => {
     expect(output).not.toContain("Genesis");
   });
 
-  test("includes static nodes regardless of filter", async () => {
+  test("excludes static nodes when keys filter is disabled", async () => {
     output = "";
     const filter: ArtifactFilter = {
       genesis: false,
@@ -140,6 +140,19 @@ describe("Selective artifact generation - screen output", () => {
       allocations: false,
     };
     await outputResult("screen", createSamplePayload(filter));
+    expect(output).not.toContain("Static Nodes");
+  });
+
+  test("includes static nodes when keys filter is enabled", async () => {
+    output = "";
+    const filter: ArtifactFilter = {
+      genesis: false,
+      keys: true,
+      abis: false,
+      subgraph: false,
+      allocations: false,
+    };
+    await outputResult("screen", createSamplePayload(filter));
     expect(output).toContain("Static Nodes");
   });
 
@@ -224,7 +237,7 @@ describe("Selective artifact generation - file output", () => {
     expect(output).toContain("besu-subgraph");
   });
 
-  test("always writes static nodes regardless of filter", async () => {
+  test("skips static nodes file when keys filter is disabled", async () => {
     const filter: ArtifactFilter = {
       genesis: false,
       keys: false,
@@ -236,7 +249,23 @@ describe("Selective artifact generation - file output", () => {
     const payload = createSamplePayload(filter);
     await outputResult("file", payload);
 
-    // Should always log about static nodes
+    // Should not log about static nodes when keys are disabled
+    expect(output).not.toContain("static-nodes");
+  });
+
+  test("writes static nodes file when keys filter is enabled", async () => {
+    const filter: ArtifactFilter = {
+      genesis: false,
+      keys: true,
+      abis: false,
+      subgraph: false,
+      allocations: false,
+    };
+    output = "";
+    const payload = createSamplePayload(filter);
+    await outputResult("file", payload);
+
+    // Should log about static nodes when keys are enabled
     expect(output).toContain("static-nodes");
   });
 });