fix(charts): update values.yaml for network and network-nodes

- Refactored values.yaml files for network and network-nodes charts to ensure consistency in image configuration.
- Added missing image details and comments for clarity, including image pull secrets and artifact descriptions.
- Updated image tag and registry settings to align with the latest configuration standards.

Author: roderik

charts/network/charts/network-bootstrapper/README.md

@@ -21,17 +21,9 @@ A Helm chart for Kubernetes
 | artifacts.external.genesis | object | `{}` | Besu genesis document rendered into the `besu-genesis` ConfigMap when `source` equals `external`. |
 | artifacts.external.staticNodes | list | `[]` | Collection of enode URIs persisted to the `besu-static-nodes` ConfigMap when `source` equals `external`. |
 | artifacts.external.validators | list | `[]` | Validator node definitions providing the data expected by the nodes chart. Each entry must include `address`, `publicKey`, `privateKey`, and `enode`. |
-| artifacts.image.pullPolicy | string | `"IfNotPresent"` |  |
-| artifacts.image.registry | string | `"ghcr.io"` |  |
-| artifacts.image.repository | string | `nil` |  |
-| artifacts.image.tag | string | `""` |  |
 | artifacts.source | string | `"generated"` | Determines how Besu network artifacts are populated. Use `generated` to run the job or `external` to supply values manually. |
 | extraInitContainers | list | `[]` | Additional init containers appended verbatim to the job pod spec. |
 | fullnameOverride | string | `"bootstrapper"` | Override for the fully qualified resource name generated by helpers. |
-| global.artifacts.image.pullPolicy | string | `nil` |  |
-| global.artifacts.image.registry | string | `nil` |  |
-| global.artifacts.image.repository | string | `nil` |  |
-| global.artifacts.image.tag | string | `nil` |  |
 | global.chainId | int | `nil` | Chain ID applied when `settings.chainId` is unset. |
 | global.labels."kots.io/app-slug" | string | `"settlemint-atk"` |  |
 | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy controlling when Kubernetes fetches updated image layers. |

charts/network/charts/network-bootstrapper/values.yaml

@@ -5,13 +5,6 @@ global:
   chainId:
   labels:
     kots.io/app-slug: settlemint-atk
-  artifacts:
-    # Image containing contract ABIs and genesis files
-    image:
-      registry:
-      repository:
-      pullPolicy:
-      tag:
 
 image:
   # -- (string) OCI registry path hosting the network bootstrapper image.
@@ -21,14 +14,6 @@ image:
   # -- (string) Image tag override; leave empty to inherit the chart appVersion.
   tag: ""
 
-artifacts:
-  # Image containing contract ABIs and genesis files
-  image:
-    registry: ghcr.io
-    repository:
-    pullPolicy: IfNotPresent
-    tag: ""
-
 # -- (list) Image pull secrets enabling access to private registries.
 imagePullSecrets: []
 

charts/network/charts/network-nodes/README.md

@@ -15,6 +15,10 @@ A Helm chart for Kubernetes
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | affinity | object | `{}` |  |
+| artifacts.image.pullPolicy | string | `"IfNotPresent"` |  |
+| artifacts.image.registry | string | `"ghcr.io"` |  |
+| artifacts.image.repository | string | `nil` |  |
+| artifacts.image.tag | string | `""` |  |
 | config.bonsaiLimitTrieLogsEnabled | bool | `false` | Emit Bonsai limit trie logs for debugging state transitions. |
 | config.cacheLastBlocks | int | `1024` | Number of recent blocks cached in memory. |
 | config.dataStorageFormat | string | `"FOREST"` | Ledger storage backend (FOREST or BONSAI). |
@@ -62,6 +66,10 @@ A Helm chart for Kubernetes
 | config.ws.maxFrameSize | int | `2097152` | Maximum WebSocket frame size in bytes. |
 | extraInitContainers | list | `[]` | Additional init containers appended verbatim to both StatefulSets. |
 | fullnameOverride | string | `"besu-node"` | Override for the fully qualified release name used in resource naming. |
+| global.artifacts.image.pullPolicy | string | `nil` |  |
+| global.artifacts.image.registry | string | `nil` |  |
+| global.artifacts.image.repository | string | `nil` |  |
+| global.artifacts.image.tag | string | `nil` |  |
 | global.labels."kots.io/app-slug" | string | `"settlemint-atk"` |  |
 | httpRoute.annotations | object | `{}` |  |
 | httpRoute.enabled | bool | `false` | Enable rendering of an HTTPRoute resource. |

charts/network/charts/network-nodes/values.yaml

@@ -3,6 +3,13 @@
 global:
   labels:
     kots.io/app-slug: settlemint-atk
+  artifacts:
+    # Image containing contract ABIs and genesis files
+    image:
+      registry:
+      repository:
+      pullPolicy:
+      tag:
 
 # -- (int) Number of RPC node replicas provisioned via StatefulSet.
 rpcReplicaCount: 2
@@ -19,6 +26,14 @@ image:
   # -- (string) Specific Besu image tag to deploy.
   tag: "25.8.0"
 
+artifacts:
+  # Image containing contract ABIs and genesis files
+  image:
+    registry: ghcr.io
+    repository:
+    pullPolicy: IfNotPresent
+    tag: ""
+
 # -- (list) Image pull secrets granting registry access for the Besu image.
 imagePullSecrets: []