fix(helm): address review feedback

Author: roderik

charts/network/charts/network-bootstrapper/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: network-bootstrapper
 description: A Helm chart for Kubernetes
 type: application
-version: 0.1.0
+version: 0.1.1
 appVersion: "0.1.0"
 maintainers:
   - name: SettleMint

charts/network/charts/network-bootstrapper/README.md

@@ -1,6 +1,6 @@
 # network-bootstrapper
 
-![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.1.0](https://img.shields.io/badge/AppVersion-0.1.0-informational?style=flat-square)
+![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.1.0](https://img.shields.io/badge/AppVersion-0.1.0-informational?style=flat-square)
 
 A Helm chart for Kubernetes
 

charts/network/charts/network-bootstrapper/templates/_helpers.tpl

@@ -60,3 +60,20 @@ Create the name of the service account to use
 {{- default "default" .Values.serviceAccount.name }}
 {{- end }}
 {{- end }}
+
+{{/*
+Render init container specifications provided via values.
+Accepts either a YAML string or a list of init container maps and indents output appropriately.
+*/}}
+{{- define "network-bootstrapper.renderInitContainers" -}}
+{{- $ctx := .context -}}
+{{- $containers := .containers -}}
+{{- $indent := .indent | default 2 -}}
+{{- if $containers -}}
+{{- if kindIs "string" $containers -}}
+{{ tpl $containers $ctx | nindent $indent }}
+{{- else -}}
+{{ tpl (toYaml $containers) $ctx | nindent $indent }}
+{{- end -}}
+{{- end -}}
+{{- end -}}

charts/network/charts/network-bootstrapper/templates/job.yaml

@@ -31,11 +31,7 @@ spec:
       {{- end }}
       {{- with .Values.initContainers }}
       initContainers:
-{{- if kindIs "string" . -}}
-{{ tpl . $ | nindent 8 }}
-{{- else -}}
-{{ tpl (toYaml .) $ | nindent 8 }}
-{{- end }}
+{{- include "network-bootstrapper.renderInitContainers" (dict "context" $ "containers" . "indent" 8) }}
       {{- end }}
       containers:
         - name: {{ .Chart.Name }}

charts/network/charts/network-nodes/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: network-nodes
 description: A Helm chart for Kubernetes
 type: application
-version: 0.1.0
+version: 0.1.1
 appVersion: "0.1.0"
 maintainers:
   - name: SettleMint

charts/network/charts/network-nodes/README.md

@@ -1,6 +1,6 @@
 # network-nodes
 
-![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.1.0](https://img.shields.io/badge/AppVersion-0.1.0-informational?style=flat-square)
+![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.1.0](https://img.shields.io/badge/AppVersion-0.1.0-informational?style=flat-square)
 
 A Helm chart for Kubernetes
 

charts/network/charts/network-nodes/templates/_helpers.tpl

@@ -69,11 +69,11 @@ Accepts either a YAML string or a list of init container maps and indents output
 {{- $ctx := .context -}}
 {{- $containers := .containers -}}
 {{- $indent := .indent | default 2 -}}
-{{- if $containers }}
-  {{- if kindIs "string" $containers -}}
+{{- if $containers -}}
+{{- if kindIs "string" $containers -}}
 {{ tpl $containers $ctx | nindent $indent }}
-  {{- else -}}
+{{- else -}}
 {{ tpl (toYaml $containers) $ctx | nindent $indent }}
-  {{- end -}}
 {{- end -}}
-{{- end }}
+{{- end -}}
+{{- end -}}