Skip to content

ci: auto-commit release assets on tags#13

Merged
roderik merged 1 commit intomainfrom
feat/tag-auto-commit
Sep 17, 2025
Merged

ci: auto-commit release assets on tags#13
roderik merged 1 commit intomainfrom
feat/tag-auto-commit

Conversation

@roderik
Copy link
Copy Markdown
Member

@roderik roderik commented Sep 17, 2025

Summary

  • load a PAT via 1Password so the workflow has push rights during release-tag runs
  • auto-commit step now uses that PAT plus explicit release-bot author info to push version bumps, chart docs, and README updates back to main when a v* tag is pushed

Testing

  • bun check
  • bun run typecheck
  • bun test

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the qa:running QA workflow is currently running label Sep 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 17, 2025

To view in Slack, search for: 1758127215.090299

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions Bot added status:ready-for-review Pull request is ready for review qa:success QA workflow passed successfully and removed qa:running QA workflow is currently running labels Sep 17, 2025
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread .github/workflows/qa.yml
Comment on lines +130 to +138
# Commit generated version metadata and README updates on release tags
- name: Auto-commit release assets
if: github.event_name == 'push' && steps.version.outputs.tag == 'latest'
uses: stefanzweifel/git-auto-commit-action@778341af668090896ca464160c2def5d1d1a3eb0 # v5
with:
commit_message: "chore(release): sync generated assets [skip ci]"
branch: main
file_pattern: 'package.json **/package.json charts/**/Chart.yaml charts/**/README.md README.md'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Grant write permissions before auto-committing release assets

The new auto-commit step pushes generated files back to main, but the job’s permissions earlier in this workflow restrict the default GITHUB_TOKEN to contents: read. With read-only token scopes, git-auto-commit-action will fail when attempting to push on release tag runs, causing the QA workflow to fail. Either increase the job’s contents permission to write or use a separate PAT so the commit can actually be created.

Useful? React with 👍 / 👎.

@roderik roderik force-pushed the feat/tag-auto-commit branch from 3f5ca06 to 826d1d5 Compare September 17, 2025 16:43
@github-actions github-actions Bot added qa:running QA workflow is currently running and removed qa:success QA workflow passed successfully labels Sep 17, 2025
@roderik roderik force-pushed the feat/tag-auto-commit branch from 826d1d5 to 1f56cd3 Compare September 17, 2025 16:46
@github-actions github-actions Bot added qa:success QA workflow passed successfully qa:running QA workflow is currently running ci CI/CD configuration changes and removed qa:running QA workflow is currently running qa:success QA workflow passed successfully labels Sep 17, 2025
@roderik roderik merged commit 18b31b3 into main Sep 17, 2025
7 checks passed
@roderik roderik deleted the feat/tag-auto-commit branch September 17, 2025 16:56
@github-actions github-actions Bot added status:merged Pull request has been merged and removed status:ready-for-review Pull request is ready for review labels Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes qa:success QA workflow passed successfully status:merged Pull request has been merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant