Skip to content

feat: update qa job for tagging #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderik merged 3 commits into from
Sep 17, 2025
Merged

feat: update qa job for tagging #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4cc856
chore(workflows): update permissions and commit user details in QA wo…
roderik Sep 17, 2025
9207061
docs(README): update CLI options for static node configuration
roderik Sep 17, 2025
5351d2f
Merge branch 'main' into qa-tag
roderik Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
(github.event_name == 'pull_request' && github.event.action != 'closed') ||
github.event_name == 'pull_request_review'
permissions:
contents: read
contents: write
pull-requests: write
issues: write
security-events: write
Expand Down Expand Up @@ -136,9 +136,10 @@ jobs:
commit_message: "chore(release): sync generated assets [skip ci]"
branch: main
file_pattern: 'package.json **/package.json charts/**/Chart.yaml charts/**/README.md README.md'
github_token: ${{ env.PAT_TOKEN }}
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Renaming 'commit_author_name' to 'commit_user_name' may break compatibility.

Verify that the action supports 'commit_user_name' and 'commit_user_email' before making this change, as using unsupported keys may prevent the commit step from working correctly.

commit_author_name: 'SettleMint Release Bot'
commit_author_email: 'support@settlemint.com'
commit_user_name: 'SettleMint Release Bot'
commit_user_email: 'support@settlemint.com'
env:
GITHUB_TOKEN: ${{ env.PAT_TOKEN }}
Comment on lines +141 to +142
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Setting GITHUB_TOKEN from PAT_TOKEN may have unintended effects.

Using a PAT for GITHUB_TOKEN increases permissions and may affect auditability and access control. Confirm this is required and that PAT_TOKEN is securely handled.


- name: Docker meta
if: github.event_name == 'pull_request' || github.event_name == 'push'
Expand Down
9 changes: 7 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,16 @@ Usage: network-bootstrapper generate [options]
Generate node identities, configure consensus, and emit a Besu genesis.

Options:
--static-node-domain <domain> DNS suffix appended to validator peer hostnames for static-nodes entries.
--static-node-namespace <name> Namespace segment inserted between service name and domain for static-nodes entries.
--static-node-service-name <name> Headless Service name used when constructing static-nodes hostnames.
--static-node-pod-prefix <prefix> StatefulSet prefix used when constructing validator pod hostnames.
--genesis-configmap-name <name> ConfigMap name that stores the generated genesis.json payload.
--static-nodes-configmap-name <name> ConfigMap name that stores the generated static-nodes.json payload.
--faucet-artifact-prefix <prefix> Prefix applied to faucet ConfigMaps and Secrets.
Comment on lines +154 to +160
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The alignment of the option descriptions is inconsistent, which harms readability. For better presentation, all descriptions should be vertically aligned. While I can only suggest a change for the new options, please consider applying this alignment to all options in this section for consistency.

Suggested change
--static-node-domain <domain> DNS suffix appended to validator peer hostnames for static-nodes entries.
--static-node-namespace <name> Namespace segment inserted between service name and domain for static-nodes entries.
--static-node-service-name <name> Headless Service name used when constructing static-nodes hostnames.
--static-node-pod-prefix <prefix> StatefulSet prefix used when constructing validator pod hostnames.
--genesis-configmap-name <name> ConfigMap name that stores the generated genesis.json payload.
--static-nodes-configmap-name <name> ConfigMap name that stores the generated static-nodes.json payload.
--faucet-artifact-prefix <prefix> Prefix applied to faucet ConfigMaps and Secrets.
--static-node-domain <domain> DNS suffix appended to validator peer hostnames for static-nodes entries.
--static-node-namespace <name> Namespace segment inserted between service name and domain for static-nodes entries.
--static-node-service-name <name> Headless Service name used when constructing static-nodes hostnames.
--static-node-pod-prefix <prefix> StatefulSet prefix used when constructing validator pod hostnames.
--genesis-configmap-name <name> ConfigMap name that stores the generated genesis.json payload.
--static-nodes-configmap-name <name> ConfigMap name that stores the generated static-nodes.json payload.
--faucet-artifact-prefix <prefix> Prefix applied to faucet ConfigMaps and Secrets.

-v, --validators <count> Number of validator nodes to generate. (default: 4)
-a, --allocations <file> Path to a genesis allocations JSON file. (default: none)
-o, --outputType <type> Output target (screen, file, kubernetes). (default: "screen")
--static-node-domain <domain> DNS suffix appended to validator peer hostnames for static-nodes entries.
--static-node-namespace <name> Namespace segment inserted between service name and domain for static-nodes entries.
--static-node-port <number> P2P port used for static-nodes enode URIs. (default: 30303)
--static-node-discovery-port <number> Discovery port used for static-nodes enode URIs. (default: 30303)
--consensus <algorithm> Consensus algorithm (IBFTv2, QBFT). (default: QBFT)
Expand Down