Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ jobs:
env:
SLACK_BOT_TOKEN: op://platform/slack-bot/SLACK_BOT_TOKEN
SLACK_CHANNEL_ID: op://platform/slack-bot/SLACK_CHANNEL_ID
HARBOR_USER: op://platform/harbor/username
HARBOR_PASS: op://platform/harbor/password
PAT_TOKEN: op://platform/github-commit-pat/credential

# Label QA as running and notify Slack (only for non-draft PRs)
Expand Down Expand Up @@ -272,27 +270,14 @@ jobs:
${{ steps.secret-scan.outcome == 'success' && 'success' || 'failure'
}}

- name: Login to Harbor
- name: Publish Helm charts to GitHub Pages
if: |
github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.draft == false)
uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3
github.event_name == 'push' &&
startsWith(github.ref, 'refs/tags/')
uses: stefanprodan/helm-gh-pages@v1.7.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

with:
registry: harbor.settlemint.com
username: ${{ env.HARBOR_USER }}
password: ${{ env.HARBOR_PASS }}

- name: Package chart
if: |
github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.draft == false)
run: bun run package:pack

- name: Push chart to Harbor
if: |
github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.draft == false)
run: bun run package:push:harbor
token: ${{ secrets.GITHUB_TOKEN }}
charts_dir: charts

# Check PR review status (PR and PR review events only)
- name: Check PR review status
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@
"test": "bun test",
"helm": "helm upgrade --install network ./charts/network -n network --create-namespace --timeout 15m",
"docs:helm": "helm-docs --chart-search-root=. --skip-version-footer",
"docs:cli": "cat README.tpl > README.md && printf '\\n```\\n' >> README.md && bun src/index.ts --help >> README.md && printf '\\n\\n' >> README.md && bun src/index.ts generate --help >> README.md && printf '\\n```\\n' >> README.md",
"package:pack": "helm package charts/network --destination .",
"package:push:harbor": "helm push ./network-*.tgz oci://harbor.settlemint.com/atk"
"docs:cli": "cat README.tpl > README.md && printf '\\n```\\n' >> README.md && bun src/index.ts --help >> README.md && printf '\\n\\n' >> README.md && bun src/index.ts generate --help >> README.md && printf '\\n```\\n' >> README.md"
},
"devDependencies": {
"@biomejs/biome": "2.2.4",
Expand Down
Loading