fix: set persistence enable to true by default

[insider89]

Summary by Sourcery

Enhancements:

• Enable persistent volume claims by default for network-nodes

[gemini-code-assist]

Summary of Changes

Hello @insider89, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a change to the default configuration for network nodes, specifically enabling persistent volume claims for ledger data by default. This adjustment aims to streamline the setup process for users who require data persistence, ensuring that storage is automatically configured without manual intervention.

Highlights

• Default Persistence: The default value for persistence.enabled has been changed from false to true in the values.yaml file for network nodes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

To view in Slack, search for: 1758185331.900049

[gemini-code-assist]

Code Review

This pull request correctly enables persistence by default, which is a sensible configuration for blockchain nodes. However, this change in default behavior is a breaking change for existing users. It's crucial to document this in the pull request description and release notes. Furthermore, introducing a breaking change warrants a major version increase for the Helm chart (e.g., to 2.0.0) to follow Semantic Versioning principles, rather than a patch release. This signals the breaking nature of the change to users.

[gemini-code-assist]

Changing this default to true constitutes a breaking change. Users who upgrade this chart and rely on the previous default (persistence disabled) will unexpectedly have persistent volumes created. This can lead to deployment failures or unintended resource consumption. Per Semantic Versioning, breaking changes should trigger a major version bump in Chart.yaml (e.g., from 1.0.13 to 2.0.0). This change should also be clearly announced in the pull request description and any release notes.