Skip to content

fix: set persistence enable to true by default #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
insider89 merged 1 commit into from
Sep 18, 2025
Merged

fix: set persistence enable to true by default #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/network/charts/network-nodes/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ readinessProbe:
# Persistent storage configuration for both validator and RPC StatefulSets.
persistence:
# -- (bool) Enable persistent volume claims for ledger data.
enabled: false
enabled: true
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Changing this default to true constitutes a breaking change. Users who upgrade this chart and rely on the previous default (persistence disabled) will unexpectedly have persistent volumes created. This can lead to deployment failures or unintended resource consumption. Per Semantic Versioning, breaking changes should trigger a major version bump in Chart.yaml (e.g., from 1.0.13 to 2.0.0). This change should also be clearly announced in the pull request description and any release notes.

# -- (string) Container path where the persistent volume is mounted.
mountPath: /data
# -- (string) Logical name for the volume when using volumeClaimTemplates.
Expand Down