Skip to content

fix: auto connect for aat tokens#162

Merged
janb87 merged 1 commit intomainfrom
jan/fix-auto-connect
Jul 3, 2025
Merged

fix: auto connect for aat tokens#162
janb87 merged 1 commit intomainfrom
jan/fix-auto-connect

Conversation

@janb87
Copy link
Copy Markdown
Collaborator

@janb87 janb87 commented Jul 3, 2025

Summary by Sourcery

Fix auto-connect logic to disable automatic workspace connection when using application access tokens by default, add a helper to derive auto-connect behavior, update related docs, action metadata, and tests.

Bug Fixes:

  • Default auto-connect to false for application access tokens to prevent unintended connections

Enhancements:

  • Introduce getAutoConnect helper to derive auto-connect behavior based on token type or explicit input
  • Convert auto-connect flag to a boolean and remove its default true from action inputs

Documentation:

  • Update README and action.yml to reflect new auto-connect defaults and improve formatting

Tests:

  • Add test for application access token scenario to verify no login or connect is performed when auto-connect is not enabled

@janb87 janb87 requested review from robbeverhelst and roderik July 3, 2025 08:17
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@janb87 janb87 enabled auto-merge (squash) July 3, 2025 08:20
@janb87 janb87 merged commit 2681afe into main Jul 3, 2025
8 checks passed
@janb87 janb87 deleted the jan/fix-auto-connect branch July 3, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants