Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
"@graphprotocol/graph-cli": "0.96.0",
"@graphprotocol/graph-ts": "0.38.0",
"@nomicfoundation/hardhat-foundry": "1.2.0",
"@nomicfoundation/hardhat-ignition-viem": "0.15.14",
"@nomicfoundation/hardhat-ignition-viem": "0.15.15",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating hardhat-ignition-viem to 0.15.15 creates a peer dependency mismatch with hardhat-ignition@0.15.13.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The pull request updates @nomicfoundation/hardhat-ignition-viem to version 0.15.15. This new version declares a peer dependency on @nomicfoundation/hardhat-ignition@^0.15.15. However, the bun.lock file indicates that @nomicfoundation/hardhat-ignition remains at 0.15.13. This version does not satisfy the ^0.15.15 requirement, which expects a version >=0.15.15 and <0.16.0. This mismatch can lead to package manager warnings or installation failures, and potentially cause runtime errors if hardhat-ignition-viem attempts to use APIs from hardhat-ignition that are not present in the older 0.15.13 version.

💡 Suggested Fix

Update @nomicfoundation/hardhat-ignition to at least version 0.15.15 to satisfy the peer dependency requirement introduced by @nomicfoundation/hardhat-ignition-viem@0.15.15.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L41

Potential issue: The pull request updates `@nomicfoundation/hardhat-ignition-viem` to
version `0.15.15`. This new version declares a peer dependency on
`@nomicfoundation/hardhat-ignition@^0.15.15`. However, the `bun.lock` file indicates
that `@nomicfoundation/hardhat-ignition` remains at `0.15.13`. This version does not
satisfy the `^0.15.15` requirement, which expects a version `>=0.15.15` and `<0.16.0`.
This mismatch can lead to package manager warnings or installation failures, and
potentially cause runtime errors if `hardhat-ignition-viem` attempts to use APIs from
`hardhat-ignition` that are not present in the older `0.15.13` version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@nomicfoundation/hardhat-toolbox-viem": "4.1.1",
"@nomiclabs/hardhat-solhint": "4.1.0",
"@openzeppelin/contracts": "5.4.0",
"@openzeppelin/subgraphs": "0.1.8-5",
"hardhat": "2.26.4",
"hardhat": "2.26.5",
"solhint": "6.0.1"
},
"overrides": {
Expand Down
Loading