fix(sfcompute-v2): update sfc-go, adopt capacities -> pools rename#5
Open
Sladuca wants to merge 3 commits into
Open
fix(sfcompute-v2): update sfc-go, adopt capacities -> pools rename#5Sladuca wants to merge 3 commits into
Sladuca wants to merge 3 commits into
Conversation
sfc-go renamed the Capacities resource to Pools (capResp.PoolResponse, client.Pools.Fetch) and the instance create/list filter field from capacity to pool (ListInstancesRequest.Pool is now a repeatable []string). Update the V2 integration to the new SDK shape. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The pool rename also changed the resource-path prefix from sfc:capacity: to sfc:pool:. Update GetDefaultPoolResourcePath (renamed from GetDefaultCapacityResourcePath) so the path the API receives is valid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Review changes with Changed Files
|
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sladuca
changed the title
Sladuca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two updates to the sfcompute-v2 provider, which is built against our preview v2 API.
sfc-gowould fail deserializing. We separately pushed an update tosfc-go- this PR updates to the new version.CapacitiestoPools. While this is not breaking (we still support the old name), we can take the opportunity here to adopt the new naming.