feat(nodes): add feature-flag-gated --enable-infiniband to sf nodes create

The option is only mounted when the user's account has the
`infiniband-preview` flag enabled (checked via the existing posthog/
feature-flag helper). When enabled, it shows up in `sf nodes create --help`
and forwards `_preview_enable_infiniband: true` to the nodes SDK, exposing
the InfiniBand preview surface in the sfcompute/sfcompute API.

Generated with [Indent](https://indent.com)
Co-Authored-By: Indent <noreply@indent.com>

Author: sigmachirality

src/lib/nodes/create.ts

@@ -21,6 +21,7 @@ import {
 } from "../../helpers/units.ts";
 import { handleNodesError, nodesClient } from "../../nodesClient.ts";
 import { GPUS_PER_NODE } from "../constants.ts";
+import { isFeatureEnabled } from "../posthog.ts";
 import {
   createNodesTable,
   durationOption,
@@ -240,7 +241,10 @@ Examples:\n
 
 async function createNodesAction(
   names: typeof create.args,
-  options: ReturnType<typeof create.opts> & { image?: string },
+  options: ReturnType<typeof create.opts> & {
+    image?: string;
+    enableInfiniband?: boolean;
+  },
 ) {
   try {
     const client = await nodesClient();
@@ -274,6 +278,7 @@ async function createNodesAction(
       cloud_init_user_data: encodedUserData,
       image_id: options.image,
       node_type: isReserved ? "reserved" : "autoreserved",
+      ...(options.enableInfiniband ? { _preview_enable_infiniband: true } : {}),
     };
 
     if (isReserved) {
@@ -497,4 +502,26 @@ async function createNodesAction(
   }
 }
 
+/**
+ * Attach the `create` subcommand to the given `nodes` parent command.
+ *
+ * Encapsulates the `infiniband-preview` feature-flag check: when the flag is
+ * enabled for the current account, `--enable-infiniband` is mounted on the
+ * command (and shows up in `sf nodes create --help`); otherwise the option is
+ * not registered and the CLI surface is unchanged. The wire field
+ * (`_preview_enable_infiniband`) is still in preview, so the option may change
+ * without notice.
+ */
+export async function registerCreate(nodes: Command) {
+  if (await isFeatureEnabled("infiniband-preview")) {
+    create.addOption(
+      new Option(
+        "--enable-infiniband",
+        "Enable InfiniBand on the nodes (preview).",
+      ),
+    );
+  }
+  nodes.addCommand(create);
+}
+
 export default create;

src/lib/nodes/index.ts

@@ -1,7 +1,7 @@
 import console from "node:console";
 import type { Command } from "@commander-js/extra-typings";
 
-import create from "./create.ts";
+import { registerCreate } from "./create.ts";
 import deleteCommand from "./delete.ts";
 import extend from "./extend.ts";
 import get from "./get.tsx";
@@ -13,15 +13,14 @@ import release from "./release.ts";
 import set from "./set.ts";
 import ssh from "./ssh.ts";
 
-export function registerNodes(program: Command) {
+export async function registerNodes(program: Command) {
   const nodes = program
     .command("nodes")
     .alias("node")
     .showHelpAfterError()
     .description("Manage compute nodes")
     .addCommand(list)
     .addCommand(get)
-    .addCommand(create)
     .addCommand(extend)
     .addCommand(release)
     .addCommand(deleteCommand)
@@ -30,6 +29,7 @@ export function registerNodes(program: Command) {
     .addCommand(ssh)
     .addCommand(logs)
     .addCommand(image);
+  await registerCreate(nodes);
 
   const baseHelpText = nodes.helpInformation();
 

src/lib/posthog.ts

@@ -62,7 +62,7 @@ const trackEvent = ({
   }
 };
 
-type FeatureFlags = "procurements" | "zones";
+type FeatureFlags = "procurements" | "zones" | "infiniband-preview";
 
 /**
  * Checks if a feature is enabled for the current user.