fix: align call sites with regenerated schema and restore image-command parity

CI's `bun run check` regressed after the openapi-typescript regen in e35a88c
because:
- `/v0/me` moved to `/v1/account/me` (with `getAccountMe` having a 2-arg call
  signature). Updated `src/index.ts`, `src/lib/posthog.ts`, and
  `src/lib/images/utils.ts` accordingly.
- `/v2/feature_flags/{feature_flag_id}` is no longer in the regenerated
  schema (only the admin variant is); switched the cli's PostHog flag check
  to a raw fetch (the route is still served externally per haproxy.conf).
- Non-OK response envelopes are now `{ error: { type, message } }` (nested);
  updated `error?.message` reads in contracts, scale/{create,list,update,utils}
  to `error?.error?.message`.

Also restores three regressions reported by the AI reviewer on the shared
image-command factory:
- Re-adds the `os` alias on `sf nodes images` and `sf vm images` so scripts
  using `sf nodes os list` / `sf vm os list` keep working.
- `sf nodes images list --json` / `sf vm images list --json` print the bare
  image array again (new `sf images list --json` keeps the envelope shape);
  controlled by a new `legacyJsonShape` factory option.
- Help text, "next steps", and overflow messages now reference the actual
  parent invocation path (`sf nodes images …` / `sf vm images …`) via a new
  `parentPath` factory option.

And re-adds the feature-flag-gated `--enable-infiniband` option on
`sf nodes create` (dropped from the create.ts factory refactor), using the
existing posthog `isFeatureEnabled("infiniband-preview")` helper.

Generated with [Indent](https://indent.com)
Co-Authored-By: Indent <noreply@indent.com>

Author: sigmachirality

src/index.ts

@@ -89,7 +89,7 @@ async function main() {
 
     if (!exchangeAccountId) {
       const client = await apiClient(config.auth_token);
-      const { data } = await client.GET("/v0/me");
+      const { data } = await client.GET("/v1/account/me", {});
       if (data?.id) {
         exchangeAccountId = data.id;
         saveConfig({ ...config, account_id: data.id });

src/lib/contracts/index.tsx

@@ -78,7 +78,7 @@ async function listContracts(
   if (!response.ok) {
     switch (response.status) {
       case 400:
-        return logAndQuit(`Bad Request: ${error?.message}`);
+        return logAndQuit(`Bad Request: ${error?.error?.message}`);
       case 401:
         return await logSessionTokenExpiredAndQuit();
       default:

src/lib/images/get.tsx

@@ -12,6 +12,7 @@ import { logAndQuit } from "../../helpers/errors.ts";
 import { formatDate } from "../../helpers/format-time.ts";
 import type { components } from "../../schema.ts";
 import { Row } from "../Row.tsx";
+import type { CreateImagesOptions } from "./index.ts";
 
 dayjs.extend(utc);
 dayjs.extend(advanced);
@@ -96,7 +97,7 @@ function formatStatusInk(status: string): React.ReactElement {
   }
 }
 
-export function createGet() {
+export function createGet(_opts: CreateImagesOptions = {}) {
   return new Command("get")
     .alias("show")
     .description("Get image details and download URL")

src/lib/images/index.ts

@@ -3,7 +3,25 @@ import { createGet } from "./get.tsx";
 import { createList } from "./list.ts";
 import { createUpload } from "./upload.ts";
 
-export function createImagesCommand() {
+export interface CreateImagesOptions {
+  /**
+   * Path users invoke this command under, used in help text and "next steps"
+   * suggestions (e.g. `"sf images"`, `"sf nodes images"`, `"sf vm images"`).
+   * Defaults to `"sf images"`.
+   */
+  parentPath?: string;
+  /**
+   * When true, `list --json` prints just the bare image array and `get --json`
+   * prints just the bare image object. Matches the pre-shared-factory output
+   * shape of `sf nodes images` / `sf vm images` so existing scripts piping
+   * `... --json | jq` keep working. Defaults to `false` (envelope shape).
+   */
+  legacyJsonShape?: boolean;
+}
+
+export function createImagesCommand(opts: CreateImagesOptions = {}) {
+  const { parentPath = "sf images", legacyJsonShape = false } = opts;
+  const subOpts = { parentPath, legacyJsonShape };
   const images = new Command("images")
     .alias("image")
     .description("Manage images")
@@ -13,18 +31,18 @@ export function createImagesCommand() {
       `
 Examples:\n
   \x1b[2m# Upload an image file\x1b[0m
-  $ sf images upload -f ./my-image.raw -n my-image
+  $ ${parentPath} upload -f ./my-image.raw -n my-image
 
   \x1b[2m# List all images\x1b[0m
-  $ sf images list
+  $ ${parentPath} list
 
   \x1b[2m# Get image details and download URL\x1b[0m
-  $ sf images get <image-id>
+  $ ${parentPath} get <image-id>
 `,
     )
-    .addCommand(createList())
-    .addCommand(createUpload())
-    .addCommand(createGet())
+    .addCommand(createList(subOpts))
+    .addCommand(createUpload(subOpts))
+    .addCommand(createGet(subOpts))
     .action(() => {
       images.help();
     });

src/lib/images/list.ts

@@ -6,9 +6,11 @@ import ora from "ora";
 import { apiClient } from "../../apiClient.ts";
 import { logAndQuit } from "../../helpers/errors.ts";
 import { formatDate } from "../../helpers/format-time.ts";
+import type { CreateImagesOptions } from "./index.ts";
 import { getDefaultWorkspace } from "./utils.ts";
 
-export function createList() {
+export function createList(opts: CreateImagesOptions = {}) {
+  const { parentPath = "sf images", legacyJsonShape = false } = opts;
   return new Command("list")
     .alias("ls")
     .description("List images")
@@ -19,13 +21,13 @@ export function createList() {
       `
 Examples:\n
   \x1b[2m# List all images\x1b[0m
-  $ sf images list
+  $ ${parentPath} list
 
   \x1b[2m# Get detailed info for a specific image\x1b[0m
-  $ sf images get <image-id>
+  $ ${parentPath} get <image-id>
 
   \x1b[2m# List images in JSON format\x1b[0m
-  $ sf images list --json
+  $ ${parentPath} list --json
 `,
     )
     .action(async (options) => {
@@ -45,7 +47,13 @@ Examples:\n
       }
 
       if (options.json) {
-        console.log(JSON.stringify(data, null, 2));
+        // legacyJsonShape: print just the bare array so existing scripts
+        // piping `... --json | jq '.[].id'` keep working under `sf nodes
+        // images list` / `sf vm images list`. Default (envelope) is the
+        // shape preferred for the new top-level `sf images list`.
+        console.log(
+          JSON.stringify(legacyJsonShape ? data.data : data, null, 2),
+        );
         return;
       }
 
@@ -54,7 +62,7 @@ Examples:\n
       if (images.length === 0) {
         console.log("No images found.");
         console.log(chalk.gray("\nUpload your first image:"));
-        console.log("  sf images upload -f ./my-image.img -n my-image");
+        console.log(`  ${parentPath} upload -f ./my-image.img -n my-image`);
         return;
       }
 
@@ -92,7 +100,7 @@ Examples:\n
             content: chalk.blackBright(
               `${images.length - 5} older ${
                 images.length - 5 === 1 ? "image" : "images"
-              } not shown. Use sf images list --json to list all images.`,
+              } not shown. Use ${parentPath} list --json to list all images.`,
             ),
           },
         ]);
@@ -103,7 +111,7 @@ Examples:\n
       console.log(chalk.gray("\nNext steps:"));
       const firstImage = sortedImages[0];
       if (firstImage) {
-        console.log(`  sf images get ${chalk.cyan(firstImage.id)}`);
+        console.log(`  ${parentPath} get ${chalk.cyan(firstImage.id)}`);
       }
       const firstCompletedImage = sortedImages.find(
         (image) => image.upload_status === "completed",

src/lib/images/upload.ts

@@ -12,6 +12,7 @@ import cliSpinners from "cli-spinners";
 import ora, { type Ora } from "ora";
 import { apiClient } from "../../apiClient.ts";
 import { logAndQuit } from "../../helpers/errors.ts";
+import type { CreateImagesOptions } from "./index.ts";
 import { getDefaultWorkspace } from "./utils.ts";
 
 async function readChunk(
@@ -53,7 +54,7 @@ async function readChunk(
   }
 }
 
-export function createUpload() {
+export function createUpload(_opts: CreateImagesOptions = {}) {
   return new Command("upload")
     .description("Upload an image file (multipart)")
     .requiredOption("-f, --file <file>", "Path to the image file")

src/lib/images/utils.ts

@@ -6,7 +6,7 @@ export async function getDefaultWorkspace(): Promise<string> {
   let accountId = config.account_id;
   if (!accountId) {
     const client = await apiClient();
-    const { data } = await client.GET("/v0/me");
+    const { data } = await client.GET("/v1/account/me", {});
     if (data?.id) {
       await saveConfig({ ...config, account_id: data.id });
       accountId = data.id;

src/lib/nodes/create.ts

@@ -21,6 +21,7 @@ import {
 } from "../../helpers/units.ts";
 import { handleNodesError, nodesClient } from "../../nodesClient.ts";
 import { GPUS_PER_NODE } from "../constants.ts";
+import { isFeatureEnabled } from "../posthog.ts";
 import {
   createNodesTable,
   durationOption,
@@ -246,6 +247,7 @@ Examples:\n
     names: typeof create.args,
     options: ReturnType<typeof create.opts> & {
       image?: string;
+      enableInfiniband?: boolean;
     },
   ) {
     try {
@@ -282,6 +284,9 @@ Examples:\n
         cloud_init_user_data: encodedUserData,
         image_id: options.image,
         node_type: isReserved ? "reserved" : "autoreserved",
+        ...(options.enableInfiniband
+          ? { _preview_enable_infiniband: true }
+          : {}),
       };
 
       if (isReserved) {
@@ -507,3 +512,26 @@ Examples:\n
     }
   }
 }
+
+/**
+ * Attach the `create` subcommand to the given `nodes` parent command.
+ *
+ * Encapsulates the `infiniband-preview` feature-flag check: when the flag is
+ * enabled for the current account, `--enable-infiniband` is mounted on the
+ * command (and shows up in `sf nodes create --help`); otherwise the option is
+ * not registered and the CLI surface is unchanged. The wire field
+ * (`_preview_enable_infiniband`) is still in preview, so the option may change
+ * without notice.
+ */
+export async function registerCreate(nodes: Command) {
+  const create = createCreateCommand();
+  if (await isFeatureEnabled("infiniband-preview")) {
+    create.addOption(
+      new Option(
+        "--enable-infiniband",
+        "Enable InfiniBand on the nodes (preview).",
+      ),
+    );
+  }
+  nodes.addCommand(create);
+}

src/lib/nodes/image/index.ts

@@ -1,3 +1,15 @@
 import { createImagesCommand } from "../../images/index.ts";
 
-export default createImagesCommand;
+/**
+ * Returns the shared images command configured for use under `sf nodes`:
+ *   - `os` alias is preserved (original `sf nodes images` had `os` and `image`).
+ *   - Help text examples reference `sf nodes images …`.
+ *   - `list --json` outputs the bare image array (matching pre-shared-factory
+ *     behavior so scripts piping `... --json | jq '.[].id'` keep working).
+ */
+export default function createNodesImagesCommand() {
+  return createImagesCommand({
+    parentPath: "sf nodes images",
+    legacyJsonShape: true,
+  }).alias("os");
+}

src/lib/nodes/index.ts

@@ -1,7 +1,7 @@
 import console from "node:console";
 import type { Command } from "@commander-js/extra-typings";
 
-import { createCreateCommand } from "./create.ts";
+import { registerCreate } from "./create.ts";
 import deleteCommand from "./delete.ts";
 import extend from "./extend.ts";
 import get from "./get.tsx";
@@ -20,8 +20,9 @@ export async function registerNodes(program: Command) {
     .showHelpAfterError()
     .description("Manage compute nodes")
     .addCommand(list)
-    .addCommand(get)
-    .addCommand(createCreateCommand())
+    .addCommand(get);
+  await registerCreate(nodes);
+  nodes
     .addCommand(extend)
     .addCommand(release)
     .addCommand(deleteCommand)