Remove Connection::DEFAULT_DEBUG_OUTPUT

Author: sferik

lib/x/client.rb

@@ -87,7 +87,7 @@ def initialize(api_key: nil, api_key_secret: nil, access_token: nil, access_toke
       open_timeout: Connection::DEFAULT_OPEN_TIMEOUT,
       read_timeout: Connection::DEFAULT_READ_TIMEOUT,
       write_timeout: Connection::DEFAULT_WRITE_TIMEOUT,
-      debug_output: Connection::DEFAULT_DEBUG_OUTPUT,
+      debug_output: nil,
       proxy_url: nil,
       default_array_class: DEFAULT_ARRAY_CLASS,
       default_object_class: DEFAULT_OBJECT_CLASS,

lib/x/connection.rb

@@ -20,8 +20,6 @@ class Connection
     DEFAULT_READ_TIMEOUT = 60 # seconds
     # Default timeout for writing requests in seconds
     DEFAULT_WRITE_TIMEOUT = 60 # seconds
-    # Default debug output destination
-    DEFAULT_DEBUG_OUTPUT = File.open(IO::NULL, "w")
     # Network errors that should be wrapped in NetworkError
     NETWORK_ERRORS = [
       Errno::ECONNREFUSED,
@@ -92,7 +90,7 @@ class Connection
     # @example Create a connection with custom timeouts
     #   connection = X::Connection.new(open_timeout: 30, read_timeout: 30)
     def initialize(open_timeout: DEFAULT_OPEN_TIMEOUT, read_timeout: DEFAULT_READ_TIMEOUT,
-      write_timeout: DEFAULT_WRITE_TIMEOUT, debug_output: DEFAULT_DEBUG_OUTPUT, proxy_url: nil)
+      write_timeout: DEFAULT_WRITE_TIMEOUT, debug_output: nil, proxy_url: nil)
       @open_timeout = open_timeout
       @read_timeout = read_timeout
       @write_timeout = write_timeout

sig/x.rbs

@@ -125,7 +125,7 @@ module X
     DEFAULT_OPEN_TIMEOUT: Integer
     DEFAULT_READ_TIMEOUT: Integer
     DEFAULT_WRITE_TIMEOUT: Integer
-    DEFAULT_DEBUG_OUTPUT: IO
+
     NETWORK_ERRORS: Array[(singleton(Errno::ECONNREFUSED) | singleton(Errno::ECONNRESET) | singleton(Net::OpenTimeout) | singleton(Net::ReadTimeout) | singleton(OpenSSL::SSL::SSLError))]
 
     @proxy_url: URI::Generic | String

test/x/client_initialization_test.rb

@@ -163,7 +163,7 @@ def test_initialize_with_default_connection_options
       assert_equal Connection::DEFAULT_OPEN_TIMEOUT, connection.open_timeout
       assert_equal Connection::DEFAULT_READ_TIMEOUT, connection.read_timeout
       assert_equal Connection::DEFAULT_WRITE_TIMEOUT, connection.write_timeout
-      assert_equal Connection::DEFAULT_DEBUG_OUTPUT, connection.debug_output
+      assert_nil connection.debug_output
       assert_nil connection.proxy_url
     end
 

test/x/connection_test.rb

@@ -14,7 +14,7 @@ def test_initialization_defaults
       assert_equal Connection::DEFAULT_OPEN_TIMEOUT, @connection.open_timeout
       assert_equal Connection::DEFAULT_READ_TIMEOUT, @connection.read_timeout
       assert_equal Connection::DEFAULT_WRITE_TIMEOUT, @connection.write_timeout
-      assert_equal Connection::DEFAULT_DEBUG_OUTPUT, @connection.debug_output
+      assert_nil @connection.debug_output
       assert_nil @connection.proxy_url
     end
 
@@ -42,7 +42,7 @@ def test_http_client_defaults
     def test_debug_output
       http_client = @connection.send(:build_http_client)
 
-      assert_equal Connection::DEFAULT_DEBUG_OUTPUT, http_client.instance_variable_get(:@debug_output)
+      assert_nil http_client.instance_variable_get(:@debug_output)
     end
 
     def test_proxy