add GeoDB cities API#148
Open
Yizhou150 wants to merge 1 commit into
Open
Conversation
Open
Contributor
Wukkkinz-0725
left a comment
Wukkkinz-0725
left a comment
There was a problem hiding this comment.
Hi Jessica,
Mostly, your geodb api looks good! I left 2 comments, which are not necessary to solve. When you finished that, let me know, then we can merge it.
| </details> | ||
|
|
||
| <details> | ||
| <summary>What's the detail information of New York CIty?</summary> |
Contributor
There was a problem hiding this comment.
It should be New York City.
| </details> | ||
|
|
||
| <details> | ||
| <summary>Get all regions with name start with "C" in a United States</summary> |
Contributor
There was a problem hiding this comment.
I am not sure if it will be better to use question sentence or not haha.
Contributor
There was a problem hiding this comment.
For me, I think sometimes directly using get ... is good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.