chore: fix linter errors (#20)

Author: sgaunet

.github/workflows/linter.yml

@@ -0,0 +1,33 @@
+name: linter
+
+on:
+  pull_request:
+  push:
+
+permissions:
+  contents: write
+
+jobs:
+  linter:
+    runs-on: ubuntu-latest
+    steps:
+      -
+        name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Install Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '>=1.24'
+      - name: Install devbox
+        uses: jetify-com/devbox-install-action@v0.13.0
+        with:
+          enable-cache: true
+          devbox-version: 0.14.0
+
+      - name: Install prerequisites
+        shell: /usr/bin/bash {0}
+        run: |
+          devbox install
+          devbox run linter

.golang-ci.yml

@@ -0,0 +1,26 @@
+---
+version: "2"
+# Configure which files to skip during linting
+run:
+  tests: false
+
+linters:
+  default: all
+
+  disable:
+    - wsl
+    - wsl_v5
+    - nlreturn
+    - depguard
+    - gochecknoinits
+    - gochecknoglobals
+    - forbidigo
+    - varnamelen
+    - exhaustruct
+    - tagliatelle
+    - noinlineerr
+    - dupl         # Duplication is expected for similar command structures
+    - ireturn      # Returning interfaces is intentional for our design
+    - err113       # We use formatted errors throughout
+    - lll          # Line length limit is too restrictive for function signatures
+    - nolintlint   # We use nolint directives where needed

.golangci.yml

@@ -9,10 +9,10 @@ tasks:
     cmds:
       - task -a
 
-  lint:
+  linter:
     desc: "Run linter"
     cmds:
-      - golangci-lint run -c .golang-ci.yml
+      - golangci-lint run
 
   binary:
     desc: "Build binary"

Taskfile.yml

@@ -1,3 +1,4 @@
+// Package cmd contains the command-line interface commands.
 package cmd
 
 import (
@@ -8,99 +9,58 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var decodeES256Cmd = &cobra.Command{
-	Use:   "es256",
-	Short: "decode JWT token",
-	Long:  `decode JWT token`,
-	Run: func(cmd *cobra.Command, args []string) {
-		var (
-			j   cryptojwt.Decoder
-			err error
-		)
-		if privateKeyFile == "" && publicKeyFile == "" {
-			fmt.Println("private key file or public key file is mandatory")
-			fmt.Println(cmd.UsageString())
-			os.Exit(1)
-		}
-		if token == "" {
-			fmt.Println("token is mandatory")
-			fmt.Println(cmd.UsageString())
-			os.Exit(1)
-		}
-		if publicKeyFile != "" {
-			j = cryptojwt.NewES256DecoderWithPublicKeyFile(publicKeyFile)
-		} else {
-			j = cryptojwt.NewES256DecoderWithPrivateKeyFile(privateKeyFile)
-		}
-		if err != nil {
-			fmt.Println(err)
-			os.Exit(1)
-		}
-		t, err := j.Decode(token)
-		if err != nil {
-			fmt.Println(err)
-			os.Exit(1)
-		}
-		fmt.Println(t)
-	},
+//nolint:dupl // Similar structure needed for different algorithms
+func createESDecodeCommand(_ /* alg */, use string, pubKeyDecoder, privKeyDecoder func(string) cryptojwt.Decoder) *cobra.Command {
+	return &cobra.Command{
+		Use:   use,
+		Short: "decode JWT token",
+		Long:  `decode JWT token`,
+		Run: func(cmd *cobra.Command, _ []string) {
+			if privateKeyFile == "" && publicKeyFile == "" {
+				fmt.Println("private key file or public key file is mandatory")
+				fmt.Println(cmd.UsageString())
+				os.Exit(1)
+			}
+			if token == "" {
+				fmt.Println("token is mandatory")
+				fmt.Println(cmd.UsageString())
+				os.Exit(1)
+			}
+			
+			var j cryptojwt.Decoder
+			if publicKeyFile != "" {
+				j = pubKeyDecoder(publicKeyFile)
+			} else {
+				j = privKeyDecoder(privateKeyFile)
+			}
+			
+			t, err := j.Decode(token)
+			if err != nil {
+				fmt.Println(err)
+				os.Exit(1)
+			}
+			fmt.Println(t)
+		},
+	}
 }
 
-var decodeES384Cmd = &cobra.Command{
-	Use:   "es384",
-	Short: "decode es384 JWT token",
-	Long:  `decode es384 JWT token`,
-	Run: func(cmd *cobra.Command, args []string) {
-		var j cryptojwt.Decoder
-		if privateKeyFile == "" && publicKeyFile == "" {
-			fmt.Println("private key file or public key file is mandatory")
-			fmt.Println(cmd.UsageString())
-			os.Exit(1)
-		}
-		if token == "" {
-			fmt.Println("token is mandatory")
-			fmt.Println(cmd.UsageString())
-			os.Exit(1)
-		}
-		if publicKeyFile != "" {
-			j = cryptojwt.NewES384DecoderWithPublicKeyFile(publicKeyFile)
-		} else {
-			j = cryptojwt.NewES384DecoderWithPrivateKeyFile(privateKeyFile)
-		}
-		t, err := j.Decode(token)
-		if err != nil {
-			fmt.Println(err)
-			os.Exit(1)
-		}
-		fmt.Println(t)
-	},
-}
+var decodeES256Cmd = createESDecodeCommand(
+	"ES256",
+	"es256",
+	cryptojwt.NewES256DecoderWithPublicKeyFile,
+	cryptojwt.NewES256DecoderWithPrivateKeyFile,
+)
 
-var decodeES512Cmd = &cobra.Command{
-	Use:   "es512",
-	Short: "decode es512 JWT token",
-	Long:  `decode es512 JWT token`,
-	Run: func(cmd *cobra.Command, args []string) {
-		var j cryptojwt.Decoder
-		if privateKeyFile == "" && publicKeyFile == "" {
-			fmt.Println("private key file or public key file is mandatory")
-			fmt.Println(cmd.UsageString())
-			os.Exit(1)
-		}
-		if token == "" {
-			fmt.Println("token is mandatory")
-			fmt.Println(cmd.UsageString())
-			os.Exit(1)
-		}
-		if publicKeyFile != "" {
-			j = cryptojwt.NewES512DecoderWithPublicKeyFile(publicKeyFile)
-		} else {
-			j = cryptojwt.NewES512DecoderWithPrivateKeyFile(privateKeyFile)
-		}
-		t, err := j.Decode(token)
-		if err != nil {
-			fmt.Println(err)
-			os.Exit(1)
-		}
-		fmt.Println(t)
-	},
-}
+var decodeES384Cmd = createESDecodeCommand(
+	"ES384",
+	"es384",
+	cryptojwt.NewES384DecoderWithPublicKeyFile,
+	cryptojwt.NewES384DecoderWithPrivateKeyFile,
+)
+
+var decodeES512Cmd = createESDecodeCommand(
+	"ES512",
+	"es512",
+	cryptojwt.NewES512DecoderWithPublicKeyFile,
+	cryptojwt.NewES512DecoderWithPrivateKeyFile,
+)