Skip to content

[Feature] Replace --is-reasoning-model with unified --reasoning flag in regenerate_train_data.py #544

@msober

Description

@msober

Checklist

Motivation

Problem

The current --is-reasoning-model flag in regenerate_train_data.py is a binary switch that only controls whether to save reasoning_content from responses. It doesn't support a common use case: using a reasoning model (e.g., Qwen3.5) with thinking explicitly disabled on the server side.

For example, SGLang supports disabling thinking via:

extra_body={"chat_template_kwargs": {"enable_thinking": False}}

But there's no way to pass this through the current CLI interface.

Proposal

Replace --is-reasoning-model (boolean) with --reasoning (choice) that supports three modes:

  • none (default): Standard model, no special handling
  • save: Save reasoning_content from responses (current --is-reasoning-model behavior)
  • disable: Explicitly disable thinking on the server side via extra_body, and do not save reasoning_content

This eliminates ambiguous flag combinations and covers the missing use case in a single parameter.

Related resources

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions