[Fix] preserve image data in preprocess for VLM training on multimodal data#532
Open
jamesahou wants to merge 2 commits intosgl-project:mainfrom
Open
[Fix] preserve image data in preprocess for VLM training on multimodal data#532jamesahou wants to merge 2 commits intosgl-project:mainfrom
jamesahou wants to merge 2 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using multimodal conversations in training,
safe_conversations_generatordrops theimagefield when loading and cleaning the data, which leadspreprocess_vlm_conversationsto fail when trying to access the image field in the conversation on this line. For example running this toy scriptyields the following:
Modifications
safe_conversations_generatorTestBuildEagle3Dataset.test_vlm_image_field_preserved) to prevent future regression. If this was failing silently, multimodal quality will likely be hurt.Related Issues
imagefield separate from the issue.Accuracy Test
Benchmark & Profiling
Checklist