feat(scaling-adapter): add Labels field for user-specified RBGSA labels#242
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
@sebest Could you please run |
@Syspretor Thanks for the review, I addressed the comment in commit 90f1214 |
|
@Syspretor I don't think the linter error is caused by my PR but I'd like to have a second opinion, let me know what you think. |
@sebest Sorry, I forgot to mention this earlier. After updating the CRD types, both
Could you please run |
|
All the signal are green now. I'll make sure to run make manifests and make generate next time I change the CRDs. |
Add a `Labels map[string]string` field to the `ScalingAdapter` struct, allowing users to specify custom labels (e.g., kwota discovery labels) on auto-created RoleBasedGroupScalingAdapter resources. The RBG controller merges user-specified labels with controller-managed labels (group-name, role-name), with controller labels always taking precedence. Labels are reconciled on both creation and subsequent updates to ensure convergence.
Regenerate deepcopy and client-go apply configuration code after adding the Labels field to ScalingAdapter.
sebest
force-pushed
the
feat/scaling-adapter-labels
branch
from
ffbcf96 to
81b5925
Compare
|
@Syspretor can I get a review ? |
@sebest I’ve reviewed it and I think this PR looks good, so I’ve merged it. Thanks for your contribution! |
2 participants
Summary
Labelsfield toScalingAdapterspec allowing users to specify custom labels on auto-created RBGSAsTest plan