fix(kustomize): fix stale references and missing CRDs in kustomization#264
Open
sebest wants to merge 1 commit into
Open
fix(kustomize): fix stale references and missing CRDs in kustomization#264sebest wants to merge 1 commit into
sebest wants to merge 1 commit into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
sebest
force-pushed
the
worktree-warm-crafting-key
branch
3 times, most recently
from
720d3e3 to
3251327
Compare
sebest
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes kustomize build config/default breakage by updating stale kustomization references and ensuring all generated CRDs are included in the CRD kustomization, then regenerates the consolidated installer manifest to reflect the corrected inputs.
Changes:
- Update RBAC kustomization to reference
role.yaml(renamed previously) instead of the stale filename. - Add the missing generated CRD base YAMLs to
config/crd/kustomization.yamlso they’re included inconfig/default. - Regenerate
deploy/kubectl/manifests.yaml(and bump controller image tag inconfig/manager/kustomization.yaml) viamake build-installer.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deploy/kubectl/manifests.yaml | Regenerated installer manifest including the full CRD set and current kustomize-rendered RBAC/manager resources. |
| config/rbac/kustomization.yaml | Fixes stale RBAC resource reference (rbgs_controller_role.yaml → role.yaml). |
| config/manager/kustomization.yaml | Updates controller image tag as part of installer regeneration. |
| config/crd/kustomization.yaml | Ensures all generated CRD bases (including coordinatedpolicies/instances/instancesets/roleinstances/roleinstancesets) are included. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebest
force-pushed
the
worktree-warm-crafting-key
branch
2 times, most recently
from
fe621a6 to
6da3f4f
Compare
- config/rbac/kustomization.yaml: update rbgs_controller_role.yaml to role.yaml (renamed in sgl-project#209 but reference not updated, breaking kustomize build) - config/crd/kustomization.yaml: add the instances and instancesets CRDs that were missing from the resources list, and sort entries alphabetically - Regenerate deploy/kubectl/manifests.yaml to reflect the two fixes above
sebest
force-pushed
the
worktree-warm-crafting-key
branch
from
6da3f4f to
04e3afd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rbgs_controller_role.yaml→role.yaml(renamed in chore(makefile): support to generate rbac in make manifests #209 but the kustomization reference was not updated, breakingkustomize build config/default)config/crd/bases/but not listed:coordinatedpolicies.workloads.x-k8s.ioinstances.workloads.x-k8s.ioinstancesets.workloads.x-k8s.ioroleinstances.workloads.x-k8s.ioroleinstancesets.workloads.x-k8s.iomake build-installerTest plan
kustomize build config/defaultsucceedsdeploy/kubectl/manifests.yaml