Dynamo do not support 'with torch.npu.device', delete it

[DevinP16]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @DevinP16, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial compatibility fix for the input_guard utility, specifically targeting scenarios where torch_compile is enabled alongside Dynamo. By conditionally bypassing the torch.npu.device context, it ensures that operations can proceed without conflict, thereby enhancing the robustness and usability of the system under compilation-optimized workflows.

Highlights

• Conditional Device Context Management: The input_guard decorator in sgl_kernel_npu/fla/utils.py has been updated to conditionally apply the custom_device_ctx. If enable_torch_compile is passed as True, the device context is skipped.
• Dynamo Compatibility Fix: This change addresses an incompatibility where Dynamo does not support torch.npu.device when enable_torch_compile is active, preventing potential errors during compilation.
• New Test Cases: A new test file tests/python/sgl_kernel_npu/fla/test_utils.py has been added to verify the correct behavior of input_guard under both enable_torch_compile=True and enable_torch_compile=False conditions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an incompatibility with torch.compile (Dynamo) by conditionally skipping the torch.npu.device context manager. The change is controlled by a new enable_torch_compile flag, and the implementation is sound. The addition of unit tests to cover both cases of this flag is a great practice and ensures the change is well-tested. I have one minor suggestion to improve code style.