for qwen3-next:add kernel fused split qkvgate gemma rmsnorm rope#405
for qwen3-next:add kernel fused split qkvgate gemma rmsnorm rope#405RuixuanZhang06 merged 6 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a performance optimization by fusing several operations related to attention mechanisms in large language models. The primary goal is to enhance the speed and efficiency of these models, specifically Qwen3-next and Coder, by reducing the overhead associated with individual operations. The fused kernel combines splitting Q, K, V, and gate, applying Gemma RMSNorm, and RoPE (Rotary Position Embedding) into a single operation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new fused Triton kernel, split_qkvgate_gemma_rmsnorm_rope, aimed at enhancing performance. While the initiative to fuse operations is commendable, the current implementation contains several critical issues within the kernel logic that will lead to incorrect behavior or runtime errors. Additionally, the wrapper function's signature has problematic default arguments that could cause unexpected failures. I've provided specific comments and suggestions to address these issues to ensure the new kernel is both correct and robust.
for qwen3-next and coder next, fuse split q,gate,k,v,reshape, gemma-rmsnorm, rope ops. enhance performance (profiling) from 100u to 40u per ops.