fix some safty problem#437
Merged
iforgetmyname merged 1 commit intosgl-project:mainfrom Apr 12, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances code safety by replacing std::memcpy with std::memcpy_s, fixing an indexing error in CheckWindowSize, and adding null pointer checks in tiling functions. It also introduces timeout detection for synchronization and updates the CeilDiv utility. Feedback was provided regarding the CeilDiv implementation, noting that the overflow check is unreliable for signed types and that T_MAX is undefined, with a suggestion for a more robust implementation.
zzx-study
force-pushed
the
330safe
branch
4 times, most recently
from
a76d33e to
3504857
Compare
iforgetmyname
approved these changes
Apr 12, 2026
zzx-study
added a commit
to zzx-study/sgl-kernel-npu
that referenced
this pull request
Apr 13, 2026
…into 330safe * 'main' of https://github.com/sgl-project/sgl-kernel-npu: Fix overflowing risk (sgl-project#440) fix safety problems (sgl-project#437) Fix security issues after LibingAI scan (sgl-project#438)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #340