Skip to content

[Spec] fold can_run_cuda_graph into EagleVerifyOutput; drop dead extend-after-decode check#25566

Merged
hnyls2002 merged 3 commits into
mainfrom
lsyin/spec-rename-and-fold-verify-output
May 18, 2026
Merged

[Spec] fold can_run_cuda_graph into EagleVerifyOutput; drop dead extend-after-decode check#25566
hnyls2002 merged 3 commits into
mainfrom
lsyin/spec-rename-and-fold-verify-output

Conversation

@hnyls2002
Copy link
Copy Markdown
Collaborator

@hnyls2002 hnyls2002 commented May 18, 2026

Rename *VerifyInput.verify -> .sample (Eagle V1, DFlash, FrozenKVMTP, Ngram); fold can_run_cuda_graph into EagleVerifyOutput (verify returns single object); drop dead check_forward_draft_extend_after_decode.


CI States

Latest PR Test (Base): ⏳ Run #26030593810
Latest PR Test (Extra): ✅ Run #26030593466

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@hnyls2002
Copy link
Copy Markdown
Collaborator Author

hnyls2002 commented May 18, 2026

/rerun-test test/registered/spec/eagle/test_eagle_infer_a.py test/registered/spec/eagle/test_eagle_infer_b.py test/registered/spec/eagle/test_eagle_dp_attention.py test/registered/spec/dflash/test_dflash.py test/registered/spec/test_spec_ngram.py test/registered/spec/test_spec_standalone.py test/registered/sessions/test_streaming_session_extra.py
(3 tries)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🚀 1-gpu-h100 (5 tests): ❌ View workflow run

cd test/ && python3 registered/spec/eagle/test_eagle_infer_a.py
cd test/ && python3 registered/spec/eagle/test_eagle_infer_b.py
cd test/ && python3 registered/spec/test_spec_ngram.py
cd test/ && python3 registered/spec/test_spec_standalone.py
cd test/ && python3 registered/sessions/test_streaming_session_extra.py

🚀 4-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/spec/eagle/test_eagle_dp_attention.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/spec/dflash/test_dflash.py

hnyls2002 added 2 commits May 17, 2026 21:57
…_draft_input/is_verify_input as cross-algo phase guards; explain pp_rank=0
@hnyls2002 hnyls2002 force-pushed the lsyin/spec-rename-and-fold-verify-output branch from cfb750e to 71a0a54 Compare May 18, 2026 04:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🚀 1-gpu-h100 (5 tests): ✅ View workflow run

cd test/ && python3 registered/spec/eagle/test_eagle_infer_a.py
cd test/ && python3 registered/spec/eagle/test_eagle_infer_b.py
cd test/ && python3 registered/spec/test_spec_ngram.py
cd test/ && python3 registered/spec/test_spec_standalone.py
cd test/ && python3 registered/sessions/test_streaming_session_extra.py

🚀 4-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/spec/eagle/test_eagle_dp_attention.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/spec/dflash/test_dflash.py

@hnyls2002 hnyls2002 force-pushed the lsyin/spec-rename-and-fold-verify-output branch from 71a0a54 to 6ff69cb Compare May 18, 2026 05:43
@hnyls2002 hnyls2002 changed the title [Spec] rename verify -> sample; fold can_run_cuda_graph [Spec] fold can_run_cuda_graph into EagleVerifyOutput; drop dead extend-after-decode check May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🚀 1-gpu-h100 (5 tests): ✅ View workflow run

cd test/ && python3 registered/spec/eagle/test_eagle_infer_a.py
cd test/ && python3 registered/spec/eagle/test_eagle_infer_b.py
cd test/ && python3 registered/spec/test_spec_ngram.py
cd test/ && python3 registered/spec/test_spec_standalone.py
cd test/ && python3 registered/sessions/test_streaming_session_extra.py

🚀 4-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/spec/eagle/test_eagle_dp_attention.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/spec/dflash/test_dflash.py

@hnyls2002 hnyls2002 merged commit 9e3bb9a into main May 18, 2026
161 of 169 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/spec-rename-and-fold-verify-output branch May 18, 2026 21:24
Shunkangz pushed a commit to Shunkangz/sglang that referenced this pull request May 27, 2026
alphabetc1 pushed a commit to alphabetc1/sglang that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant