[sgl-kernel] Fix MUSA wheel METADATA version to match +musa<suffix> filename#25573
Closed
Kangyan-Zhou wants to merge 1 commit into
Closed
[sgl-kernel] Fix MUSA wheel METADATA version to match +musa<suffix> filename#25573Kangyan-Zhou wants to merge 1 commit into
Kangyan-Zhou wants to merge 1 commit into
Conversation
…ilename The MUSA rename script only renamed the .whl file (e.g. inserting +musa43), leaving the dist-info METADATA Version untouched. pip 22.2+ rejects such wheels with "inconsistent version" because the filename and METADATA disagree. The CUDA rename script (sgl-kernel/rename_wheels.sh) already handles this correctly by unpacking, patching METADATA + WHEEL tags, and repacking via `wheel pack`. Port the same flow to the MUSA script so MUSA wheels are installable via the wheel index. The change is also idempotent: a rerun on an already-suffixed wheel detects the existing +musa tag in METADATA and skips it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
@johnnycxm Please take a look. Thanks! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MUSA wheel rename script only renames the
.whlfile (inserting+musa43into the filename) but leaves the dist-infoMETADATAVersion:field untouched. pip 22.2+ rejects such wheels with:This means
pip install sglang-kernel --index-url https://docs.sglang.io/whl/musa43currently fails for every published MUSA wheel (v0.4.1.post1, v0.4.2, v0.4.2.post1).The CUDA companion
sgl-kernel/rename_wheels.shalready handles this correctly (unpack → patch METADATA + WHEEL →wheel packto regenerate RECORD). This PR ports that flow toscripts/ci/musa/rename_wheels_musa.sh.Changes
scripts/ci/musa/rename_wheels_musa.sh:python -m wheel unpack.WHEELTag:line solinux_*is rewritten tomanylinux2014_*in lockstep with the filename.METADATAVersion:line to append+musa<suffix>..dist-infodirectory.python -m wheel pack(regeneratesRECORDchecksums).Version:, substitution actually landed, dist-info dir actually renamed) so a malformed wheel surfaces a clear error instead of a misleadingsed: /WHEELfailure downstream.Test Plan
Local sanity-check (cannot run the full MUSA CI from this environment):
sglang-kernel-0.4.2.post2-cp310-none-linux_x86_64.whland ran the script with43as the suffix arg.dist/wheel:sglang_kernel-0.4.2.post2+musa43-cp310-none-manylinux2014_x86_64.whlVersion: 0.4.2.post2+musa43Tag: cp310-none-manylinux2014_x86_64pip install --platform manylinux2014_x86_64 --python-version 3.10 --only-binary=:all: ...accepts the wheel — no "inconsistent version" complaint.For the next release, this script needs to run as part of
build-musa43in.github/workflows/release-whl-kernel.yml:444-450(it already does — no workflow change needed).Follow-up
The already-published wheels in
sgl-project/whlreleases (v0.4.1.post1, v0.4.2, v0.4.2.post1) still have stale METADATA. They will need either re-uploaded assets or a new patch release beforepip install sglang-kernel --index-url ...works for existing MUSA tags.CI States
Latest PR Test (Base): ❌ Missing
run-cilabel — add it to run CI tests.Latest PR Test (Extra): ❌ Blocked —
run-ciis required first.