Skip to content

Commit 0ec0a60

Browse files
author
Shahen Hovhannisyan
committed
fix(VideoPlayer): Rotation bug
The video is duplicated when rotate={true} because filterView's frame referencet to playerLayout's frame and not for bounds
1 parent fe23d04 commit 0ec0a60

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

ios/RNVideoProcessing/RNVideoPlayer.swift

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ class RNVideoPlayer: RCTView {
5656
override init(frame: CGRect) {
5757
super.init(frame: frame)
5858
playerLayer = AVPlayerLayer.init(player: player)
59-
// self.layer.addSublayer(playerLayer!)
60-
// playerLayer?.frame = self.bounds
61-
// self.layer.needsDisplayOnBoundsChange = true
6259
}
6360

6461
required init?(coder aDecoder: NSCoder) {
@@ -247,8 +244,9 @@ class RNVideoPlayer: RCTView {
247244
filterView.bounds.size.height = self._playerHeight
248245
}
249246
filterView.frame.origin = CGPoint.zero
250-
playerLayer?.frame = filterView.frame
251247
self.filterView.transform = CGAffineTransform(rotationAngle: rotationAngle)
248+
playerLayer?.frame = filterView.bounds
249+
self.setNeedsLayout()
252250
self.layoutIfNeeded()
253251
}
254252
}
@@ -349,6 +347,7 @@ class RNVideoPlayer: RCTView {
349347
playerLayer!.frame = filterView.bounds
350348
playerLayer!.videoGravity = self._resizeMode
351349
playerLayer!.masksToBounds = true
350+
playerLayer!.removeFromSuperlayer()
352351
filterView.layer.addSublayer(playerLayer!)
353352

354353
print("CHANGED playerframe \(playerLayer), frameAAA \(playerLayer?.frame)")

0 commit comments

Comments
 (0)