Skip to content

Commit 41c9c54

Browse files
kesha-antonovShahen Hovhannisyan
authored andcommitted
fix(trim): accuracy (#101)
1 parent 4b134a3 commit 41c9c54

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

android/src/main/java/com/shahenlibrary/Trimmer/Trimmer.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -562,16 +562,22 @@ static void crop(String source, ReadableMap options, final Promise promise, Reac
562562
ArrayList<String> cmd = new ArrayList<String>();
563563
cmd.add("-y"); // NOTE: OVERWRITE OUTPUT FILE
564564

565+
// NOTE: INPUT FILE
566+
cmd.add("-i");
567+
cmd.add(source);
568+
569+
// NOTE: PLACE ARGUMENTS FOR FFMPEG IN THIS ORDER:
570+
// 1. "-i" (INPUT FILE)
571+
// 2. "-ss" (START TIME)
572+
// 3. "-to" (END TIME) or "-t" (TRIM TIME)
573+
// OTHERWISE WE WILL LOSE ACCURACY AND WILL GET WRONG CLIPPED VIDEO
574+
565575
String startTime = options.getString("startTime");
566576
if ( !startTime.equals(null) && !startTime.equals("") ) {
567577
cmd.add("-ss");
568578
cmd.add(startTime);
569579
}
570580

571-
// NOTE: INPUT FILE
572-
cmd.add("-i");
573-
cmd.add(source);
574-
575581
String endTime = options.getString("endTime");
576582
if ( !endTime.equals(null) && !endTime.equals("") ) {
577583
cmd.add("-to");

0 commit comments

Comments
 (0)