Skip to content

Commit 196504a

Browse files
authored
Update Shakapacker to 10.2.0 (#771)
* Update Shakapacker to 10.2.0 * Stabilize destroy comment system spec * Keep css-loader on compatible v6 line * Minimize Shakapacker lockfile refresh * Add Rspack dev server dependency
1 parent 251625f commit 196504a

5 files changed

Lines changed: 152 additions & 147 deletions

File tree

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ruby "3.4.6"
77

88
gem "cpflow", "5.1.1", require: false
99
gem "react_on_rails_pro", "17.0.0.rc.6"
10-
gem "shakapacker", "10.1.0"
10+
gem "shakapacker", "10.2.0"
1111

1212
# Bundle edge Rails instead: gem "rails", github: "rails/rails"
1313
gem "rails", "~> 8.1.2"

Gemfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ GEM
290290
nio4r (~> 2.0)
291291
racc (1.8.1)
292292
rack (3.2.6)
293-
rack-proxy (0.8.2)
293+
rack-proxy (0.8.3)
294294
rack
295295
rack-session (2.1.2)
296296
base64 (>= 0.1.0)
@@ -446,7 +446,7 @@ GEM
446446
websocket (~> 1.0)
447447
semantic_range (3.1.1)
448448
sexp_processor (4.17.1)
449-
shakapacker (10.1.0)
449+
shakapacker (10.2.0)
450450
activesupport (>= 5.2)
451451
package_json
452452
rack-proxy (>= 0.6.1)
@@ -561,7 +561,7 @@ DEPENDENCIES
561561
scss_lint
562562
sdoc
563563
selenium-webdriver (~> 4)
564-
shakapacker (= 10.1.0)
564+
shakapacker (= 10.2.0)
565565
spring
566566
spring-commands-rspec
567567
stimulus-rails (~> 1.3)

package.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@
4747
"@rails/actioncable": "7.0.5",
4848
"@rescript/core": "^0.5.0",
4949
"@rescript/react": "^0.11.0",
50-
"@rspack/cli": "2.0.0-beta.7",
51-
"@rspack/core": "2.0.0-beta.7",
50+
"@rspack/cli": "2.0.4",
51+
"@rspack/core": "2.0.4",
5252
"@swc/core": "^1.13.5",
5353
"ajv": "^8.17.1",
5454
"autoprefixer": "^10.4.14",
5555
"axios": "^0.21.1",
5656
"classnames": "^2.3.2",
5757
"compression-webpack-plugin": "10.0.0",
58-
"css-loader": "^6.7.3",
58+
"css-loader": "^6.8.1",
5959
"css-minimizer-webpack-plugin": "^5.0.1",
6060
"es5-shim": "^4.6.7",
6161
"estraverse": "^5.3.0",
@@ -100,7 +100,7 @@
100100
"sass": "^1.58.3",
101101
"sass-loader": "^13.3.2",
102102
"sass-resources-loader": "^2.2.5",
103-
"shakapacker": "10.1.0",
103+
"shakapacker": "10.2.0",
104104
"stimulus": "^3.0.1",
105105
"style-loader": "^3.3.1",
106106
"swc-loader": "^0.2.6",
@@ -116,7 +116,8 @@
116116
"devDependencies": {
117117
"@babel/eslint-parser": "^7.16.5",
118118
"@babel/preset-react": "^7.18.6",
119-
"@rspack/plugin-react-refresh": "1.6.1",
119+
"@rspack/dev-server": "^2.0.4",
120+
"@rspack/plugin-react-refresh": "2.0.0",
120121
"@tailwindcss/typography": "^0.5.10",
121122
"@testing-library/dom": "^10.4.1",
122123
"@testing-library/jest-dom": "^6.9.1",
@@ -147,7 +148,7 @@
147148
"react-refresh": "^0.14.0",
148149
"react-transform-hmr": "^1.0.4",
149150
"regenerator-runtime": "^0.13.11",
150-
"rspack-manifest-plugin": "^5.1.0",
151+
"rspack-manifest-plugin": "^5.2.2",
151152
"typescript": "^5.1.3",
152153
"webpack-dev-server": "^4.11.1"
153154
},

spec/system/destroy_comment_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
click_link "New Comment"
1414
submit_form(name: comment.author, text: comment.text)
15+
expect(page).to have_css("#notice", text: "Comment was successfully created.")
1516
click_link "Back"
1617

1718
accept_confirm do

0 commit comments

Comments
 (0)