Skip to content

Commit 92ae507

Browse files
authored
Fix SSR renderer URL VM global (#781)
1 parent 4830aa3 commit 92ae507

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

renderer/node-renderer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
const path = require('path');
2+
const { URL } = require('node:url');
23
const { reactOnRailsProNodeRenderer } = require('react-on-rails-pro-node-renderer');
34

45
const isProduction = process.env.NODE_ENV === 'production';

spec/requests/server_render_check_spec.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,13 @@
1111
.to include("Comments")
1212
end
1313

14+
it "server renders RouterApp NavLinks that require the URL VM global" do
15+
get root_path
16+
html_nodes = response.parsed_body
17+
18+
expect(html_nodes.at_css("#RouterApp-react-component-0 a[href='/react-router']").text).to eq("Route")
19+
end
20+
1421
it "generates no server rendered HTML if server rendering not enabled" do
1522
get simple_path
1623
html_nodes = Nokogiri::HTML(response.body)

0 commit comments

Comments
 (0)