Skip to content

Update HorizontalForm.res with demo text #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justin808 wants to merge 5 commits into from
Closed

Update HorizontalForm.res with demo text #734

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40da736
Update HorizontalForm.res with demo text
justin808 May 9, 2026
7dcb979
Update client/app/bundles/comments/rescript/CommentForm/forms/Horizon…
justin808 May 21, 2026
27feb42
Update comment author label in HorizontalForm
justin808 May 21, 2026
3afab4d
Use Node 24 GitHub action versions
justin808 May 21, 2026
9db5381
Update label text in HorizontalForm.res
justin808 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cpflow-cleanup-stale-review-apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/cpflow-delete-review-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
# the trust boundary. All local composite actions below are therefore loaded from
# trusted base-branch code; keep them that way when changing this workflow.
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

@claude claude Bot May 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a mutable major-version tag (@v6) means the tag can be silently re-pointed to different code at any time, which is a supply chain risk. Per GitHub's security hardening guide, pin to the full commit SHA instead:

Suggested change
uses: actions/checkout@v6
uses: actions/checkout@<FULL-SHA-FOR-v6> # v6

The same applies to every actions/checkout@v6 and actions/github-script@v8 reference across all 6 workflow files changed in this PR.

with:
# Delete only invokes `cpln`/`cpflow`; no git push happens, so drop the
# GITHUB_TOKEN credential helper to keep the token out of .git/config under
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:

- name: Set workflow links
if: steps.config.outputs.ready == 'true'
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const workflowUrl = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
Expand All @@ -94,7 +94,7 @@ jobs:
- name: Create initial PR comment
if: steps.config.outputs.ready == 'true'
id: create-comment
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const comment = await github.rest.issues.createComment({
Expand All @@ -117,7 +117,7 @@ jobs:
# created the initial PR comment and workflow link env vars it updates.
- name: Finalize delete status
if: always() && steps.config.outputs.ready == 'true'
uses: actions/github-script@v7
uses: actions/github-script@v8
env:
COMMENT_ID: ${{ steps.create-comment.outputs.comment-id }}
JOB_STATUS: ${{ job.status }}
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/cpflow-deploy-review-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:

steps:
- name: Checkout trusted workflow sources
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
# Keep generated composite actions on the trusted base branch. The PR
# application code is checked out separately under ./app after source
Expand Down Expand Up @@ -164,7 +164,7 @@ jobs:

- name: Checkout PR commit
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true'
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
ref: ${{ env.PR_SHA }}
path: app
Expand Down Expand Up @@ -251,7 +251,7 @@ jobs:
- name: Create initial PR comment
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
id: create-comment
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const result = await github.rest.issues.createComment({
Expand All @@ -264,7 +264,7 @@ jobs:

- name: Set deployment links
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const workflowUrl = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
Expand All @@ -277,7 +277,7 @@ jobs:
- name: Initialize GitHub deployment
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
id: init-deployment
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const deployment = await github.rest.repos.createDeployment({
Expand All @@ -302,7 +302,7 @@ jobs:

- name: Update PR comment with build status
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
uses: actions/github-script@v7
uses: actions/github-script@v8
env:
COMMENT_ID: ${{ steps.create-comment.outputs.comment-id }}
with:
Expand Down Expand Up @@ -343,7 +343,7 @@ jobs:

- name: Update PR comment with deploy status
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
uses: actions/github-script@v7
uses: actions/github-script@v8
env:
COMMENT_ID: ${{ steps.create-comment.outputs.comment-id }}
with:
Expand Down Expand Up @@ -399,7 +399,7 @@ jobs:

- name: Finalize deployment status
if: always() && steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
uses: actions/github-script@v7
uses: actions/github-script@v8
env:
COMMENT_ID: ${{ steps.create-comment.outputs.comment-id }}
DEPLOYMENT_ID: ${{ steps.init-deployment.outputs.result }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cpflow-deploy-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

- name: Checkout repository
if: steps.check-branch.outputs.is_deployable == 'true'
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

Expand All @@ -79,7 +79,7 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cpflow-help-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
# Help only reads `.github/cpflow-help.md`; no git push happens, so drop the
# GITHUB_TOKEN credential helper to keep the token out of .git/config.
persist-credentials: false

- name: Post help message
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const fs = require("fs");
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cpflow-promote-staging-to-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cpflow-review-app-help.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
timeout-minutes: 5
steps:
- name: Post quick reference
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const body = [
Expand Down
1 change: 1 addition & 0 deletions client/app/bundles/comments/rescript/CommentForm/forms/HorizontalForm.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ let make = (~author, ~handleAuthorChange, ~text, ~handleTextChange, ~handleSubmi
<div className="flex flex-col gap-0 items-center lg:gap-4 lg:flex-row">
<label htmlFor="comment_author" className="w-full lg:w-2/12 lg:text-end shrink-0">
{"Name"->React.string}
{"XXXXXXXX"->React.string}

@claude claude Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks like accidental placeholder/debug text. "XXXXXXXX" has no semantic meaning and will render visibly in the UI, making the Name label read "NameXXXXXXXX".

Suggested change
{"XXXXXXXX"->React.string}

This line should be removed before merging.

@chatgpt-codex-connector chatgpt-codex-connector Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove placeholder text from the author field label

The new "XXXXXXXX" string is rendered unconditionally inside the comment_author label, so the UI now shows NameXXXXXXXX to every user in the main comment form. This looks like debug/demo placeholder content rather than product copy and degrades form clarity in production unless manually reverted.

Useful? React with 👍 / 👎.

@claude claude Bot May 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line renders the label as "NameXXXXXXXX" in the UI. It looks like debug/demo text that was left in accidentally — the PR title even calls it "demo text." This must be removed before merging.

Suggested change
{"XXXXXXXX"->React.string}

</label>
<input
type_="text"
Expand Down
Loading