Update React on Rails 17.0.0-rc.2 stack#765
Conversation
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
WalkthroughThis PR updates the React-on-Rails ecosystem package versions across dependency manifests and documentation. The ChangesDependency Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis is a dependency-only version bump from
Confidence Score: 5/5This is a clean dependency-only bump; all five files are internally consistent and no logic was modified. Every changed file is a version manifest or documentation update. The Gemfile, Gemfile.lock, package.json, and yarn.lock are mutually consistent — pinned constraints match resolved versions, and the yarn.lock hashes correspond to published packages. No application code, configuration logic, or migration files were touched. The known test failures noted in the PR description are infrastructure-related (the Pro Node renderer not running locally) rather than regressions introduced by this diff. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: Update RoR 17.0.0-rc.2 stack] --> B[Ruby / Gem changes]
A --> C[JS / npm changes]
B --> B1["Gemfile\nreact_on_rails_pro 16.7.0.rc.3 → 17.0.0.rc.2"]
B1 --> B2["Gemfile.lock\nreact_on_rails 17.0.0.rc.2\nreact_on_rails_pro 17.0.0.rc.2"]
C --> C1["package.json\nreact-on-rails-pro 17.0.0-rc.2\nreact-on-rails-pro-node-renderer 17.0.0-rc.2\nreact-on-rails-rsc 19.0.5-rc.7"]
C1 --> C2["yarn.lock\nAll 4 packages: new resolved URLs + integrity hashes"]
A --> D[Docs]
D --> D1["README.md\nVersion Targets table updated\nreact-on-rails-rsc entry added"]
Reviews (1): Last reviewed commit: "Update React on Rails RC stack" | Re-trigger Greptile |
Code Review: Update React on Rails 17.0.0-rc.2 stackOverviewThis is a clean, dependency-only PR that bumps the React on Rails ecosystem from What looks good
Concerns1. Pre-release versions on master (Medium)All pinned versions ( 2. RSpec suite could not be fully validated (Medium)The PR body notes 47 out of 48 RSpec tests failed due to the Pro Node renderer not being available at 3. Version divergence between
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| "react-on-rails-rsc": "19.0.5-rc.6", | ||
| "react-on-rails-pro": "17.0.0-rc.2", | ||
| "react-on-rails-pro-node-renderer": "17.0.0-rc.2", | ||
| "react-on-rails-rsc": "19.0.5-rc.7", |
There was a problem hiding this comment.
react-on-rails-rsc is versioned independently from the rest of the pro packages (17.0.0-rc.2), so the major-version gap (19 vs 17) is intentional. That said, it can be jarring for contributors expecting a uniform version across the ecosystem. Consider adding a short comment in the README's Version Targets section (e.g. "react-on-rails-rsc uses its own versioning scheme and does not track the main react-on-rails major version") to prevent confusion.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
✅ Review App DeletedReview app for PR #765 is deleted |
1 participant
Summary
Updates the legacy source-backed tutorial app to the React on Rails 17.0.0-rc.2 release stack for the React on Rails 17 RC batch.
References shakacode/react_on_rails#3898.
Updated versions
react_on_railsgem:17.0.0.rc.2viareact_on_rails_proreact_on_rails_progem:17.0.0.rc.2react-on-railsnpm package:17.0.0-rc.2viareact-on-rails-proreact-on-rails-pronpm package:17.0.0-rc.2react-on-rails-pro-node-renderernpm package:17.0.0-rc.2react-on-rails-rscnpm package:19.0.5-rc.7shakapackerremains at10.1.0Verification
bin/conductor-exec bundle install-> passedbin/conductor-exec yarn install-> passedbin/conductor-exec bundle check-> passedbin/conductor-exec yarn install --frozen-lockfile --non-interactive-> passedgit diff --check-> passedbin/conductor-exec bundle exec rubocop-> passed, 57 files inspected, no offensesbin/conductor-exec yarn test:client-> passed, 4 suites / 16 testsbin/conductor-exec bundle exec rake react_on_rails:locale && RAILS_ENV=test bin/conductor-exec bin/rails react_on_rails:generate_packs && bin/conductor-exec yarn res:build && bin/conductor-exec yarn build:test-> passed, webpack completed with existing DefinePlugin warningsbin/conductor-exec yarn lint:eslint-> failed on existing JS/format/generated-pack lint violations unrelated to this dependency-only diffbin/conductor-exec yarn lint:prettier-> failed on existing formatting differences unrelated to this dependency-only diffRAILS_ENV=test bin/conductor-exec bundle exec rails db:prepare && bin/conductor-exec bundle exec rspec-> failed after DB setup because the Pro Node renderer was not running on127.0.0.1:3800with matchingRENDERER_PASSWORD; 47/48 failures were renderer auth/connection failuresNotes
Local version confirmation:
react_on_rails 17.0.0.rc.2,react_on_rails_pro 17.0.0.rc.2,shakapacker 10.1.0react-on-rails 17.0.0-rc.2,react-on-rails-pro 17.0.0-rc.2,react-on-rails-pro-node-renderer 17.0.0-rc.2,react-on-rails-rsc 19.0.5-rc.7,shakapacker 10.1.0Note
Medium Risk
Major-version bump of SSR/RSC integration gems and npm packages can change renderer behavior; scope is limited to version pins with verified bundle/client tests but full RSpec needs the Pro Node renderer running.
Overview
Bumps the tutorial app to the React on Rails 17.0.0-rc.2 release line across Ruby and JavaScript, with no application source changes.
Ruby:
react_on_rails_proinGemfilemoves from16.7.0.rc.3to17.0.0.rc.2, which pullsreact_on_railsto the same version inGemfile.lock.npm:
react-on-rails-pro,react-on-rails-pro-node-renderer, and transitivereact-on-railsgo to17.0.0-rc.2;react-on-rails-rscgoes from19.0.5-rc.6to19.0.5-rc.7.shakapackerstays at10.1.0.Docs:
README.mdversion targets are updated to match the new pins.Reviewed by Cursor Bugbot for commit 4c1bbe3. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit