Update React on Rails to 17.0.0.rc.3#767
Conversation
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
WalkthroughThis PR bumps the ChangesReact on Rails Pro RC Dependency Upgrade
🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code ReviewOverviewClean, focused dependency bump from React on Rails 17.0.0.rc.2 → 17.0.0.rc.3 (both Ruby gem and npm packages). No application logic changes — only version pins, lockfile updates, and README docs. What's Changed
Code Quality ✅
Testing ✅The PR description includes a thorough RC Test Report covering all critical paths:
Observations
VerdictApproved. The change is exactly what it claims to be, lockfiles are correct, all documented tests pass, and the scope is appropriately minimal for an RC bump. |
Greptile SummaryThis PR bumps the React on Rails Pro ecosystem from
Confidence Score: 5/5Pure RC version bump across lockfiles and README; no logic, config, or API surface changes. All changes are mechanical version string replacements in Gemfile, Gemfile.lock, package.json, yarn.lock, and README. The lockfiles are internally consistent — the pinned equality constraint in Gemfile.lock matches the resolved version, and all three npm packages in yarn.lock carry fresh integrity hashes with no leftover rc.2 entries. The PR description documents that install, build, lint, and client tests passed locally. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Ruby["Ruby (Gemfile / Gemfile.lock)"]
A["react_on_rails_pro\n17.0.0.rc.2 → 17.0.0.rc.3"] --> B["react_on_rails\n17.0.0.rc.2 → 17.0.0.rc.3"]
end
subgraph JS["JavaScript (package.json / yarn.lock)"]
C["react-on-rails-pro\n17.0.0-rc.2 → 17.0.0-rc.3"] --> E["react-on-rails\n17.0.0-rc.2 → 17.0.0-rc.3"]
D["react-on-rails-pro-node-renderer\n17.0.0-rc.2 → 17.0.0-rc.3"]
end
subgraph Unchanged["Unchanged"]
F["react-on-rails-rsc 19.0.5-rc.7"]
G["shakapacker 10.1.0"]
end
Reviews (1): Last reviewed commit: "Update React on Rails to 17.0.0.rc.3" | Re-trigger Greptile |
✅ Review App DeletedReview app for PR #767 is deleted |
Summary
Updates this tutorial app to consume React on Rails 17.0.0.rc.3 / 17.0.0-rc.3.
react_on_rails_progem to17.0.0.rc.3react-on-rails-proandreact-on-rails-pro-node-rendererto17.0.0-rc.3react_on_rails/react-on-railsalso resolve to RC3Tracker: shakacode/react_on_rails#3823
RC Test Report
Branch/head SHA:
jg-codex/update-react-on-rails-17-rc3/fdb6e065c33514cf04cb2861527ae567983e8884Commands run:
bin/conductor-exec bundle update react_on_rails_pro react_on_rails-> passed; updatedreact_on_rails_proandreact_on_railsfrom17.0.0.rc.2to17.0.0.rc.3bin/conductor-exec yarn add --exact react-on-rails-pro@17.0.0-rc.3 react-on-rails-pro-node-renderer@17.0.0-rc.3-> passed; updated direct Pro npm packages and transitivereact-on-railsto17.0.0-rc.3bin/conductor-exec bundle install-> passedbin/conductor-exec yarn install --frozen-lockfile-> passedbin/conductor-exec yarn build:test-> passed; ReScript compile, locale generation, pack generation, and client/server/RSC webpack builds completedbin/conductor-exec bundle exec rubocop-> passed; 57 files inspected, no offenses detectedbin/conductor-exec yarn test:client-> passed; 4 test suites, 16 testsNotes:
pry-docreports Ruby 3.4.6 is unsupported, Browserslist/baseline-browser-mapping data is stale, and webpack reports duplicate DefinePlugin NODE_ENV values. None failed the commands.Labels
Labels: none. This is a focused dependency RC bump with local install, build, lint, and client test coverage.
Note
Low Risk
No application code changes; only version pins and lockfile updates for an RC dependency bump.
Overview
Bumps the tutorial app from React on Rails 17.0.0.rc.2 to 17.0.0.rc.3 across Ruby and JavaScript.
The
react_on_rails_progem inGemfileis updated, withGemfile.lockaligning transitivereact_on_rails/react_on_rails_proto RC3. NPM pinsreact-on-rails-proandreact-on-rails-pro-node-rendererto17.0.0-rc.3, andyarn.lockupdates the matchingreact-on-railstransitive. README Version Targets bullets are updated to document RC3.Reviewed by Cursor Bugbot for commit fdb6e06. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit