Skip to content

Commit 0833cd1

Browse files
committed
Release incremental context on early errors
1 parent 03b74a7 commit 0833cd1

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

  • packages/react-on-rails-pro-node-renderer/src

packages/react-on-rails-pro-node-renderer/src/worker.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,8 +796,16 @@ export default function run(config: Partial<Config>) {
796796
await closeRequestPromise;
797797
} else {
798798
// Response hasn't started yet, we can send an error response
799+
const closeRequestPromise = closeIncrementalRequest({
800+
timeoutMs: INCREMENTAL_REQUEST_CLOSE_TIMEOUT_MS,
801+
});
799802
const errorResponse = errorResponseResult(errorMessage, incrementalTracingContext);
800-
await setResponse(errorResponse, res);
803+
try {
804+
await setResponse(errorResponse, res);
805+
} finally {
806+
markIncrementalResponseFinished();
807+
await closeRequestPromise;
808+
}
801809
}
802810
}
803811
});

0 commit comments

Comments
 (0)