Commit 2c40bf8
Unskip Rspack RSC e2e tests on react-on-rails-rsc 19.2 (rc.3) (#4173)
## Summary
`react_on_rails_rsc#105` — the Rspack RSC build skipping the
client-references module map on the 19.2 line, so RSC client content
never rendered/hydrated under Rspack — is fixed in
`react-on-rails-rsc@19.2.0-rc.2`. This re-enables the 7 Pro/RSC dummy
e2e tests that were conditionally skipped under the Rspack gate
(`RSPACK_RSC_BROKEN_192`) pending that fix.
## Changes
- Bump the Pro/RSC dummy dep and the
`react_on_rails_pro_dummy>react-on-rails-rsc` pnpm override from
`19.2.0-rc.1` → `19.2.0-rc.3` (rc.3 carries the rc.2 fix); refresh
`pnpm-lock.yaml` and the override comment.
- Remove the `RSPACK_RSC_BROKEN_192` / `RSPACK_RSC_SKIP_REASON` guards
and the now-unused constants:
- `react_on_rails_pro/spec/dummy/e2e-tests/rsc_route_ssr_false.spec.ts`
— 3 skips
- `react_on_rails_pro/spec/dummy/e2e-tests/rsc_fouc.spec.ts` — 4 skips
## Why now
rc.2 (2026-06-17) and rc.3 (2026-06-21) shipped the Rspack module-map
fix and `react_on_rails_rsc#105` is closed. Until now these tests were
silently skipped under Rspack, so a regression on that path would not be
caught during the 19.2 soak.
## Validation
- Local: prettier + eslint clean on the changed specs.
- The real proof is hosted CI: `rspack-dummy-app-tests` +
`dummy-app-rspack-rsc-runtime-gate` now run the previously-skipped
RSC-render assertions on rc.3. Requested `ready-for-hosted-ci`.
## Scope / risk
Test-only + dummy-app dependency change. The published **17.0.0 default
RSC pin stays at stable `19.0.5`** (the 19.2 line remains opt-in,
tracked by #3865). No published-package source is touched, so no
CHANGELOG entry.
Context: `react_on_rails_rsc#105`, #3865, #4072.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Updated `react-on-rails-rsc` dependency to version 19.2.0-rc.3.
* **Tests**
* Enabled RSC streaming and route rendering tests that were previously
skipped, improving test coverage for React Server Components
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent 1db1e20 commit 2c40bf8
5 files changed
Lines changed: 9 additions & 35 deletions
File tree
- react_on_rails_pro/spec/dummy
- e2e-tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | 310 | | |
321 | 311 | | |
322 | 312 | | |
| |||
330 | 320 | | |
331 | 321 | | |
332 | 322 | | |
333 | | - | |
334 | 323 | | |
335 | 324 | | |
336 | 325 | | |
| |||
346 | 335 | | |
347 | 336 | | |
348 | 337 | | |
349 | | - | |
350 | 338 | | |
351 | 339 | | |
352 | 340 | | |
| |||
360 | 348 | | |
361 | 349 | | |
362 | 350 | | |
363 | | - | |
364 | 351 | | |
365 | 352 | | |
366 | 353 | | |
| |||
416 | 403 | | |
417 | 404 | | |
418 | 405 | | |
419 | | - | |
420 | 406 | | |
421 | 407 | | |
422 | 408 | | |
| |||
Lines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 29 | | |
39 | 30 | | |
40 | | - | |
41 | 31 | | |
42 | 32 | | |
43 | 33 | | |
| |||
85 | 75 | | |
86 | 76 | | |
87 | 77 | | |
88 | | - | |
89 | 78 | | |
90 | 79 | | |
91 | 80 | | |
| |||
136 | 125 | | |
137 | 126 | | |
138 | 127 | | |
139 | | - | |
140 | 128 | | |
141 | 129 | | |
142 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
0 commit comments