Skip to content

Commit 30231ea

Browse files
docs(planning): record #3293 closure + related-PR status table (#3280)
Add §6 documenting that the experiment codebase PR #3293 is closed (superseded by this plan), with a disposition table for #3293/#3298/this PR, and an explicit note that orthogonal #3217 is left untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent e88bc4c commit 30231ea

1 file changed

Lines changed: 17 additions & 1 deletion

File tree

internal/planning/json-render-body-migration-plan.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ implementation still needs. It is not itself the implementation.
1212
| Artifact | Location |
1313
| -------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
1414
| Issue | https://github.com/shakacode/react_on_rails/issues/3280 |
15-
| Experiment PR (the "demo") | https://github.com/shakacode/react_on_rails/pull/3293 |
15+
| Experiment PR (the "demo") **closed** | [#3293](https://github.com/shakacode/react_on_rails/pull/3293) (closed; experiment fully captured in this doc — see note below) |
1616
| Experiment commit (react_on_rails) | [`352743ef1`](https://github.com/shakacode/react_on_rails/commit/352743ef18b204bb34072b42aa8be32f05927bfa)`[EXPERIMENT] Send render request body as JSON when no bundle attached` |
1717
| Experiment branch | `experiment/3280-json-render-body` (base `upcoming-v16.3.0`) |
1818
| Demo-app harness commit (rsc-benchmar) | [`b90977ef3`](https://github.com/AbanoubGhadban/rsc-benchmar/commit/b90977ef33d72c33aacbce09b07d66db46b46155)`demo(#3280): JSON render-body experiment harness + parallel A/B tooling` |
@@ -359,3 +359,19 @@ re-litigate #3217's numbers, only note that the JSON win was re-verified with
359359
Open a single production PR implementing §4.1–§4.6, gated on a protocol
360360
version bump (§4.1) so old renderers keep getting form-encoded bodies. Target
361361
the same release train as #3217 if possible; they compound.
362+
363+
## 6. Status of related PRs
364+
365+
The experiment was intentionally throwaway (no tests/version-negotiation/docs,
366+
per the issue). Its codebase-change PR has been **closed** — everything it
367+
contained (the diff, the numbers, the problems, the production plan) is
368+
preserved in this document. Production work will be a fresh PR per §5.
369+
370+
| PR | Branch | Status | Disposition |
371+
|---|---|---|---|
372+
| [#3293](https://github.com/shakacode/react_on_rails/pull/3293) | `experiment/3280-json-render-body` | **closed** | Experiment code (9-line `render_code` flip + instrumentation). Superseded by this plan; not for merge. Diff preserved verbatim in §1. |
373+
| [#3298](https://github.com/shakacode/react_on_rails/pull/3298) | `docs/3280-json-render-body-plan` (vs `upcoming-v16.3.0`) | closed | Earlier draft of this doc; relocated and re-targeted to `main`. |
374+
| this PR | `docs/3280-json-render-body-plan` (vs `main`) | open | This document. The only #3280 PR that stays open. |
375+
376+
[#3217](https://github.com/shakacode/react_on_rails/pull/3217) (TCP_NODELAY)
377+
is a separate issue's PR, orthogonal to #3280 (§2.6) — **left untouched**.

0 commit comments

Comments
 (0)