Skip to content

Commit 5c13228

Browse files
committed
Address review comments
1 parent 59e24a3 commit 5c13228

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

packages/react-on-rails/tests/webpackHelpers.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('webpackHelpers', () => {
88
expect(reactDomClientWarning.test(message)).toBe(true);
99
});
1010

11-
it('matches the webpack 4 "Module not found" warning for react-dom/client', () => {
11+
it('matches the "Module not found" warning regardless of file path', () => {
1212
const message =
1313
"Module not found: Error: Can't resolve 'react-dom/client' in '/app/node_modules/react-on-rails/src'";
1414
expect(reactDomClientWarning.test(message)).toBe(true);

react_on_rails_pro/react_on_rails_pro.gemspec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ Gem::Specification.new do |s|
4444
# https://github.com/HoneyryderChuck/httpx/issues/118
4545
s.add_runtime_dependency "http-2", ">= 1.1.1"
4646
s.add_runtime_dependency "httpx", "~> 1.5"
47+
# jwt >= 2.7 is sufficient: decode_license validates RS256 (asymmetric) only,
48+
# so the empty-key HMAC advisory fixed in jwt 3.2.0 does not apply here.
49+
# algorithms: ["RS256"] is honored by both jwt 2.x and 3.x; see license_validator.rb.
4750
s.add_runtime_dependency "jwt", ">= 2.7"
4851
s.add_runtime_dependency "rainbow"
4952
s.add_runtime_dependency "react_on_rails", ReactOnRails::VERSION

0 commit comments

Comments
 (0)