Preserve legacy node renderer env parsing

Author: justin808

CHANGELOG.md

@@ -30,7 +30,7 @@ After a release, run `/update-changelog` in Claude Code to analyze commits, writ
 
 #### Added
 
-- **[Pro]** **Built-in node renderer `/health` and `/ready` probe endpoints**: The node renderer can now register first-class liveness (`GET /health` -> `200` with a status-only body) and readiness (`GET /ready` -> `503` until the answering worker is online and has at least one server bundle compiled, then `200`) endpoints, replacing the hand-rolled `configureFastify` health-check recipe for the common case. The endpoints are off by default and enabled with the new `enableHealthEndpoints` config option (or `RENDERER_ENABLE_HEALTH_ENDPOINTS=true`, `TRUE`, `yes`, `YES`, or `1`); they are unauthenticated like `/info` but expose no runtime version or path details. Includes a new [Health and Readiness Endpoints](docs/oss/building-features/node-renderer/health-checks.md) docs page with working Kubernetes (`tcpSocket` + `exec` with `curl --http2-prior-knowledge` -- the h2c listener cannot be probed with HTTP/1.1 `httpGet`), ECS, and Docker Compose probe examples. The shared node-renderer truthy parser also accepts `1` for other boolean env vars that use it directly, including `RENDERER_SUPPORT_MODULES` and `REPLAY_SERVER_ASYNC_OPERATION_LOGS`. Closes [Issue 3880](https://github.com/shakacode/react_on_rails/issues/3880). [PR 3939](https://github.com/shakacode/react_on_rails/pull/3939) by [justin808](https://github.com/justin808).
+- **[Pro]** **Built-in node renderer `/health` and `/ready` probe endpoints**: The node renderer can now register first-class liveness (`GET /health` -> `200` with a status-only body) and readiness (`GET /ready` -> `503` until the answering worker is online and has at least one server bundle compiled, then `200`) endpoints, replacing the hand-rolled `configureFastify` health-check recipe for the common case. The endpoints are off by default and enabled with the new `enableHealthEndpoints` config option (or `RENDERER_ENABLE_HEALTH_ENDPOINTS=true`, `TRUE`, `yes`, `YES`, or `1`); they are unauthenticated like `/info` but expose no runtime version or path details. The `1` alias is scoped to `RENDERER_ENABLE_HEALTH_ENDPOINTS` so existing node-renderer boolean environment flags keep their previous parsing behavior. Includes a new [Health and Readiness Endpoints](docs/oss/building-features/node-renderer/health-checks.md) docs page with working Kubernetes (`tcpSocket` + `exec` with `curl --http2-prior-knowledge` -- the h2c listener cannot be probed with HTTP/1.1 `httpGet`), ECS, and Docker Compose probe examples. Closes [Issue 3880](https://github.com/shakacode/react_on_rails/issues/3880). [PR 3939](https://github.com/shakacode/react_on_rails/pull/3939) by [justin808](https://github.com/justin808).
 
 #### Fixed
 

docs/oss/building-features/node-renderer/health-checks.md

@@ -25,9 +25,8 @@ probes cannot carry it). Keep the renderer on `localhost` or private networking
 The endpoints are **off by default**. Enable them with the `enableHealthEndpoints` config option or the
 `RENDERER_ENABLE_HEALTH_ENDPOINTS` environment variable (`true`, `TRUE`, `yes`, `YES`, or `1`):
 
-Those string values are parsed by the shared node-renderer `truthy()` helper, so the same accepted values also apply
-to other boolean environment variables that use that helper directly, such as `RENDERER_SUPPORT_MODULES` and
-`REPLAY_SERVER_ASYNC_OPERATION_LOGS`.
+The `1` alias is scoped to `RENDERER_ENABLE_HEALTH_ENDPOINTS`; other node-renderer boolean environment variables keep
+their existing parsing behavior.
 
 ```js
 // renderer/node-renderer.js

llms-full.txt

@@ -13282,9 +13282,8 @@ probes cannot carry it). Keep the renderer on `localhost` or private networking
 The endpoints are **off by default**. Enable them with the `enableHealthEndpoints` config option or the
 `RENDERER_ENABLE_HEALTH_ENDPOINTS` environment variable (`true`, `TRUE`, `yes`, `YES`, or `1`):
 
-Those string values are parsed by the shared node-renderer `truthy()` helper, so the same accepted values also apply
-to other boolean environment variables that use that helper directly, such as `RENDERER_SUPPORT_MODULES` and
-`REPLAY_SERVER_ASYNC_OPERATION_LOGS`.
+The `1` alias is scoped to `RENDERER_ENABLE_HEALTH_ENDPOINTS`; other node-renderer boolean environment variables keep
+their existing parsing behavior.
 
 ```js
 // renderer/node-renderer.js
@@ -27270,7 +27269,7 @@ After a release, run `/update-changelog` in Claude Code to analyze commits, writ
 
 #### Added
 
-- **[Pro]** **Built-in node renderer `/health` and `/ready` probe endpoints**: The node renderer can now register first-class liveness (`GET /health` -> `200` with a status-only body) and readiness (`GET /ready` -> `503` until the answering worker is online and has at least one server bundle compiled, then `200`) endpoints, replacing the hand-rolled `configureFastify` health-check recipe for the common case. The endpoints are off by default and enabled with the new `enableHealthEndpoints` config option (or `RENDERER_ENABLE_HEALTH_ENDPOINTS=true`, `TRUE`, `yes`, `YES`, or `1`); they are unauthenticated like `/info` but expose no runtime version or path details. Includes a new [Health and Readiness Endpoints](docs/oss/building-features/node-renderer/health-checks.md) docs page with working Kubernetes (`tcpSocket` + `exec` with `curl --http2-prior-knowledge` -- the h2c listener cannot be probed with HTTP/1.1 `httpGet`), ECS, and Docker Compose probe examples. The shared node-renderer truthy parser also accepts `1` for other boolean env vars that use it directly, including `RENDERER_SUPPORT_MODULES` and `REPLAY_SERVER_ASYNC_OPERATION_LOGS`. Closes [Issue 3880](https://github.com/shakacode/react_on_rails/issues/3880). [PR 3939](https://github.com/shakacode/react_on_rails/pull/3939) by [justin808](https://github.com/justin808).
+- **[Pro]** **Built-in node renderer `/health` and `/ready` probe endpoints**: The node renderer can now register first-class liveness (`GET /health` -> `200` with a status-only body) and readiness (`GET /ready` -> `503` until the answering worker is online and has at least one server bundle compiled, then `200`) endpoints, replacing the hand-rolled `configureFastify` health-check recipe for the common case. The endpoints are off by default and enabled with the new `enableHealthEndpoints` config option (or `RENDERER_ENABLE_HEALTH_ENDPOINTS=true`, `TRUE`, `yes`, `YES`, or `1`); they are unauthenticated like `/info` but expose no runtime version or path details. The `1` alias is scoped to `RENDERER_ENABLE_HEALTH_ENDPOINTS` so existing node-renderer boolean environment flags keep their previous parsing behavior. Includes a new [Health and Readiness Endpoints](docs/oss/building-features/node-renderer/health-checks.md) docs page with working Kubernetes (`tcpSocket` + `exec` with `curl --http2-prior-knowledge` -- the h2c listener cannot be probed with HTTP/1.1 `httpGet`), ECS, and Docker Compose probe examples. Closes [Issue 3880](https://github.com/shakacode/react_on_rails/issues/3880). [PR 3939](https://github.com/shakacode/react_on_rails/pull/3939) by [justin808](https://github.com/justin808).
 
 #### Fixed
 

packages/react-on-rails-pro-node-renderer/src/shared/configBuilder.ts

@@ -216,6 +216,10 @@ function defaultReplayServerAsyncOperationLogs() {
   return env.NODE_ENV?.toLowerCase() === 'development';
 }
 
+function truthyHealthEndpointFlag(value: unknown) {
+  return value === '1' || truthy(value);
+}
+
 const defaultConfig: Config = {
   // Use env port if we run on Heroku
   port: Number(env.RENDERER_PORT) || DEFAULT_PORT,
@@ -268,7 +272,7 @@ const defaultConfig: Config = {
   maxVMPoolSize: (env.MAX_VM_POOL_SIZE && parseInt(env.MAX_VM_POOL_SIZE, 10)) || 2,
 
   // Built-in /health and /ready probe endpoints are opt-in.
-  enableHealthEndpoints: truthy(env.RENDERER_ENABLE_HEALTH_ENDPOINTS),
+  enableHealthEndpoints: truthyHealthEndpointFlag(env.RENDERER_ENABLE_HEALTH_ENDPOINTS),
 };
 
 function envValuesUsed() {
@@ -410,7 +414,7 @@ export function buildConfig(providedUserConfig?: Partial<Config>): Config {
     password: env.RENDERER_PASSWORD,
     // Re-evaluate env-derived defaults at build time in case env vars are set post-import.
     replayServerAsyncOperationLogs: defaultReplayServerAsyncOperationLogs(),
-    enableHealthEndpoints: truthy(env.RENDERER_ENABLE_HEALTH_ENDPOINTS),
+    enableHealthEndpoints: truthyHealthEndpointFlag(env.RENDERER_ENABLE_HEALTH_ENDPOINTS),
   };
   config = { ...runtimeDefaultConfig, ...userConfig };
   if (explicitUndefinedPassword) {
@@ -441,7 +445,7 @@ export function buildConfig(providedUserConfig?: Partial<Config>): Config {
 
   config.supportModules = truthy(config.supportModules);
   // Coerce in case a user config passes an env-derived string (e.g. "true").
-  config.enableHealthEndpoints = truthy(config.enableHealthEndpoints);
+  config.enableHealthEndpoints = truthyHealthEndpointFlag(config.enableHealthEndpoints);
 
   if (config.maxVMPoolSize <= 0 || !Number.isInteger(config.maxVMPoolSize)) {
     throw new Error('maxVMPoolSize must be a positive integer');

packages/react-on-rails-pro-node-renderer/src/shared/truthy.ts

@@ -14,12 +14,5 @@
  */
 
 export default function truthy(value: unknown) {
-  return (
-    value === true ||
-    value === '1' ||
-    value === 'YES' ||
-    value === 'TRUE' ||
-    value === 'yes' ||
-    value === 'true'
-  );
+  return value === true || value === 'YES' || value === 'TRUE' || value === 'yes' || value === 'true';
 }

packages/react-on-rails-pro-node-renderer/src/worker.ts

@@ -718,6 +718,7 @@ export default function run(config: Partial<Config>) {
     // Safe from a rate-limiting perspective (CodeQL js/missing-rate-limiting):
     // this is an internal renderer service not exposed to the internet, returns
     // a static status string, and exposes no sensitive runtime data.
+    // codeql[js/missing-rate-limiting]
     // lgtm[js/missing-rate-limiting]
     app.get('/health', (_req, res) => {
       res.send({ status: 'ok' });
@@ -731,6 +732,7 @@ export default function run(config: Partial<Config>) {
     // across workers, so a probe checks one worker per request.
     // Safe from a rate-limiting perspective (CodeQL js/missing-rate-limiting):
     // same rationale as /health; this returns only a static readiness status.
+    // codeql[js/missing-rate-limiting]
     // lgtm[js/missing-rate-limiting]
     app.get('/ready', (_req, res) => {
       if (hasAnyVMContext()) {

packages/react-on-rails-pro-node-renderer/tests/configBuilder.test.ts

@@ -21,6 +21,8 @@ describe('configBuilder', () => {
     'RENDERER_PASSWORD',
     'RAILS_ENV',
     'REPLAY_SERVER_ASYNC_OPERATION_LOGS',
+    'RENDERER_ENABLE_HEALTH_ENDPOINTS',
+    'RENDERER_SUPPORT_MODULES',
     'RENDERER_WORKERS_COUNT',
   ] as const;
   const savedEnvValues = Object.fromEntries(envVarsToRestore.map((key) => [key, process.env[key]]));
@@ -102,6 +104,36 @@ describe('configBuilder', () => {
     expect(envValues.RENDERER_PASSWORD).toBe(false);
   });
 
+  it('keeps shared boolean env parsing backward-compatible for RENDERER_SUPPORT_MODULES=1', () => {
+    process.env.NODE_ENV = 'test';
+    process.env.RENDERER_SUPPORT_MODULES = '1';
+
+    const { buildConfig } = loadConfigBuilderWithMockedLogger();
+    const config = buildConfig();
+
+    expect(config.supportModules).toBe(false);
+  });
+
+  it('keeps shared boolean env parsing backward-compatible for REPLAY_SERVER_ASYNC_OPERATION_LOGS=1', () => {
+    process.env.NODE_ENV = 'test';
+    process.env.REPLAY_SERVER_ASYNC_OPERATION_LOGS = '1';
+
+    const { buildConfig } = loadConfigBuilderWithMockedLogger();
+    const config = buildConfig();
+
+    expect(config.replayServerAsyncOperationLogs).toBe(false);
+  });
+
+  it('accepts RENDERER_ENABLE_HEALTH_ENDPOINTS=1 without changing other boolean env flags', () => {
+    process.env.NODE_ENV = 'test';
+    process.env.RENDERER_ENABLE_HEALTH_ENDPOINTS = '1';
+
+    const { buildConfig } = loadConfigBuilderWithMockedLogger();
+    const config = buildConfig();
+
+    expect(config.enableHealthEndpoints).toBe(true);
+  });
+
   it('masks module-load password defaults in sanitized logs', () => {
     process.env.RENDERER_PASSWORD = 'env-password';
     const { buildConfig, logSanitizedConfig, info } = loadConfigBuilderWithMockedLogger();