Skip to content

Commit bbf71aa

Browse files
committed
Address review feedback after CI rebase
1 parent b580a3f commit bbf71aa

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

.github/actions/setup-bundle/action.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: Setup Bundler dependencies
2-
description: Setup Ruby, cache, and install gems for a Bundler project.
2+
description: >
3+
Setup Ruby, cache, and install gems for a Bundler project. On Linux,
4+
ensure libyaml-dev is already present or install it before calling this action.
35
46
inputs:
57
working-directory:

.github/workflows/benchmark.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -659,14 +659,14 @@ jobs:
659659
# when the pinned hash isn't in its DB. A single combined pattern
660660
# avoids false-positive matches across unrelated lines.
661661
if [ $BENCHER_EXIT_CODE -ne 0 ] && grep -q "Head Version.*not found" "$BENCHER_STDERR" && ! grep -qiE "alert|threshold violation|boundary violation" "$BENCHER_STDERR"; then
662-
if [ -n "$START_POINT_HASH_ARG" ]; then
663-
RETRY_ARGS="${START_POINT_ARGS/$START_POINT_HASH_ARG/}"
664-
else
665-
RETRY_ARGS="$START_POINT_ARGS"
666-
fi
667-
if [ "$RETRY_ARGS" != "$START_POINT_ARGS" ]; then
668-
echo ""
669-
echo "⚠️ Start-point hash not found in Bencher — retrying without --start-point-hash (will use latest baseline)"
662+
if [ -n "$START_POINT_HASH_ARG" ]; then
663+
RETRY_ARGS="${START_POINT_ARGS/$START_POINT_HASH_ARG/}"
664+
else
665+
RETRY_ARGS="$START_POINT_ARGS"
666+
fi
667+
if [ "$RETRY_ARGS" != "$START_POINT_ARGS" ]; then
668+
echo ""
669+
echo "⚠️ Start-point hash not found in Bencher — retrying without --start-point-hash (will use latest baseline)"
670670
echo "::warning::Start-point hash not found in Bencher — falling back to latest baseline for comparison"
671671
set +e
672672
run_bencher "$RETRY_ARGS" > bench_results/bencher_report.html 2>"$BENCHER_STDERR"

0 commit comments

Comments
 (0)