Skip to content

Commit ca43f11

Browse files
committed
Avoid duplicate RSC install warning command
1 parent 0036788 commit ca43f11

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

react_on_rails/lib/generators/react_on_rails/js_dependency_manager.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,8 +464,7 @@ def rsc_dependency_pin_failed_warning
464464
"All RSC projects are temporarily pinned to that version because the unversioned " \
465465
"`latest` tag may not export react-on-rails-rsc/RspackPlugin until stable 19.0.5 " \
466466
"is published, so the generator left the version pin in package.json rather than " \
467-
"install a potentially incompatible version. " \
468-
"Run #{manual_add_packages_command(rsc_packages_with_pin)} to finish setup."
467+
"install a potentially incompatible version."
469468
end
470469

471470
def remove_base_package_if_present

react_on_rails/spec/react_on_rails/generators/js_dependency_manager_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -700,6 +700,7 @@ def errors
700700
expect(warning_text).to include("react-on-rails-rsc/RspackPlugin")
701701
# the manual instruction points at the pinned version, not the unversioned package
702702
expect(warning_text).to include("npm install --save-exact react-on-rails-rsc@19.0.5-rc.6")
703+
expect(warning_text.scan("npm install --save-exact react-on-rails-rsc@19.0.5-rc.6").size).to eq(1)
703704
end
704705

705706
it "keeps the rspack pin in the manual install instruction when the pinned install raises" do

0 commit comments

Comments
 (0)