Keep renderer benchmarks on the active wire protocol

Author: alexeyr

benchmarks/bench-node-renderer.rb

@@ -41,6 +41,8 @@ def read_password_from_config
 BASE_URL = env_or_default("BASE_URL", "localhost:3800")
 PROTOCOL_VERSION = read_protocol_version
 LOAD_GENERATOR_SHARDS = env_or_default("LOAD_GENERATOR_SHARDS", 1).to_i
+RAW_RENDER_CONTENT_TYPE = "application/vnd.react-on-rails.render-request+javascript"
+RAW_RENDER_PROTOCOL_HEADER = "X-React-On-Rails-Pro-Protocol-Version"
 
 # Test cases: JavaScript expressions to evaluate
 # Format: { name: "test_name", request: "javascript_code", rsc: true/false }
@@ -105,8 +107,10 @@ def rsc_bundle?(bundle_timestamp)
   # Use curl with h2c since Net::HTTP doesn't support HTTP/2
   result, status = Open3.capture2(
     "curl", "-s", "--http2-prior-knowledge", "-X", "POST",
-    "-H", "Content-Type: application/x-www-form-urlencoded",
-    "-d", body,
+    "-H", "Content-Type: #{RAW_RENDER_CONTENT_TYPE}",
+    "-H", "#{RAW_RENDER_PROTOCOL_HEADER}: #{PROTOCOL_VERSION}",
+    "-H", "Authorization: Bearer #{PASSWORD}",
+    "--data-binary", body,
     url
   )
   return nil unless status.success?
@@ -145,23 +149,14 @@ def categorize_bundles(bundles)
   [rsc_bundle, non_rsc_bundle]
 end
 
-# URL-encode special characters for form body
-def url_encode(str)
-  URI.encode_www_form_component(str)
-end
-
 # Build render URL for a bundle and render name
 def render_url(bundle_timestamp, render_name)
   "http://#{BASE_URL}/bundles/#{bundle_timestamp}/render/#{render_name}"
 end
 
 # Build request body for a rendering request
 def render_body(rendering_request)
-  [
-    "protocolVersion=#{url_encode(PROTOCOL_VERSION)}",
-    "password=#{url_encode(PASSWORD)}",
-    "renderingRequest=#{url_encode(rendering_request)}"
-  ].join("&")
+  rendering_request
 end
 
 def validate_node_renderer_benchmark_config!
@@ -380,7 +375,9 @@ def run_vegeta_benchmark(test_case, bundle_timestamp, shard_count: LOAD_GENERATO
   # Write targets file (Vegeta format with @body reference)
   File.write(targets_file, <<~TARGETS)
     POST #{target_url}
-    Content-Type: application/x-www-form-urlencoded
+    Content-Type: #{RAW_RENDER_CONTENT_TYPE}
+    #{RAW_RENDER_PROTOCOL_HEADER}: #{PROTOCOL_VERSION}
+    Authorization: Bearer #{PASSWORD}
     @#{body_file}
   TARGETS
 

benchmarks/spec/bench_node_renderer_spec.rb

@@ -141,6 +141,32 @@ def add(name:, rps:, p50:, status:, p90: nil)
   end
 
   describe "#run_vegeta_benchmark" do
+    it "sends the rendering request verbatim using the raw renderer protocol" do
+      stub_const("CONNECTIONS", 1)
+      stub_const("MAX_CONNECTIONS", 1)
+      stub_const("RATE", "max")
+      stub_const("DURATION", "1s")
+
+      writes = {}
+      allow(File).to receive(:write) { |path, contents| writes[path] = contents }
+      allow(FileUtils).to receive(:rm_f)
+      allow(Process).to receive_messages(spawn: 1, wait2: [1, process_status(success: true)])
+      allow(self).to receive_messages(system: true, parse_json_file: { "throughput" => 1,
+                                                                       "latencies" => { "50th" => 1_000_000,
+                                                                                        "90th" => 2_000_000 },
+                                                                       "status_codes" => { "200" => 1 } })
+
+      rendering_request = 'render({quoted: "value & more"})'
+      run_vegeta_benchmark({ name: "raw_request", request: rendering_request }, "bundleX", shard_count: 1)
+
+      expect(writes.fetch("#{OUTDIR}/raw_request_vegeta_body.txt")).to eq(rendering_request)
+      expect(writes.fetch("#{OUTDIR}/raw_request_vegeta_targets.txt")).to include(
+        "Content-Type: #{RAW_RENDER_CONTENT_TYPE}",
+        "#{RAW_RENDER_PROTOCOL_HEADER}: #{PROTOCOL_VERSION}",
+        "Authorization: Bearer #{PASSWORD}"
+      )
+    end
+
     it "runs all shards concurrently before merging their result streams into one Vegeta report" do
       stub_const("CONNECTIONS", 10)
       stub_const("MAX_CONNECTIONS", 10)