Skip to content

Commit e57b4f1

Browse files
justin808claude
andcommitted
Exclude .lychee.toml from triggering code test workflows (#2882)
## Summary Fixes the issue where PR #2876 (docs-only changes including `.lychee.toml`) triggered all code test workflows. **Root cause**: `.lychee.toml` is a docs-infrastructure config file (for the markdown link checker) but it wasn't excluded from code test workflows in two places: 1. **Workflow `paths-ignore`**: `.lychee.toml` doesn't match `**.md` or `docs/**`, so all code workflows triggered 2. **`ci-changes-detector` script**: `.lychee.toml` hit the catch-all `*` pattern, which set `UNCATEGORIZED_CHANGED=true` and ran the **entire** test suite **Fix**: - Added `.lychee.toml` to `paths-ignore` in all 10 code test workflow files so they don't trigger at all - Added `.lychee.toml` to the documentation pattern in `ci-changes-detector` so it's classified as docs-only (defense in depth) The `check-markdown-links.yml` workflow already correctly includes `.lychee.toml` in its `paths:` trigger — that's the only workflow that should care about it. ## Test plan - [ ] Verify this PR itself only triggers `detect-changes`, `markdown-link-check`, and `claude-review` — not code tests - [ ] Confirm `check-markdown-links.yml` still triggers when `.lychee.toml` changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: limited to CI trigger/changed-file classification logic, with no runtime/app behavior changes; primary risk is inadvertently skipping intended CI runs when `.lychee.toml` changes. > > **Overview** > Prevents docs-infra changes to `.lychee.toml` from triggering the main code test suite. > > Adds `.lychee.toml` to `paths-ignore` across code-related GitHub Actions workflows (including benchmarks) and updates `script/ci-changes-detector` to classify `.lychee.toml` as documentation-only so it no longer falls into the catch-all “run everything” path. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 869d5d4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Optimized CI workflows to treat `.lychee.toml` as a documentation-only file, preventing unnecessary test suite triggers when only this configuration file is modified. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4741e6a commit e57b4f1

11 files changed

Lines changed: 12 additions & 1 deletion

.github/workflows/benchmark.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,13 @@ on:
5454
paths-ignore:
5555
- '**.md'
5656
- 'docs/**'
57+
- '.lychee.toml'
5758
pull_request:
5859
types: [opened, synchronize, reopened, labeled]
5960
paths-ignore:
6061
- '**.md'
6162
- 'docs/**'
63+
- '.lychee.toml'
6264
# Cancel stale PR benchmark runs when new commits are pushed.
6365
# Main runs are never cancelled so every merge is measured.
6466
concurrency:

.github/workflows/examples.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
workflow_dispatch:
1314
inputs:
1415
force_run:

.github/workflows/gem-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'packages/**'
1314
- 'react_on_rails_pro/**'
1415
workflow_dispatch:

.github/workflows/integration-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'react_on_rails_pro/**'
1314
workflow_dispatch:
1415
inputs:

.github/workflows/lint-js-and-ruby.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'react_on_rails_pro/**'
1314
workflow_dispatch:
1415
inputs:

.github/workflows/package-js-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'react_on_rails/lib/**'
1314
- 'react_on_rails/spec/react_on_rails/**'
1415
- 'react_on_rails_pro/**'

.github/workflows/precompile-check.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
paths-ignore:
99
- '**.md'
1010
- 'docs/**'
11+
- '.lychee.toml'
1112
- 'react_on_rails_pro/**'
1213
workflow_dispatch:
1314
inputs:

.github/workflows/pro-integration-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'react_on_rails/lib/**'
1314
- 'react_on_rails/spec/**'
1415
- 'packages/react_on_rails/**'

.github/workflows/pro-lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'react_on_rails/lib/**'
1314
- 'react_on_rails/spec/**'
1415
- 'packages/react_on_rails/**'

.github/workflows/pro-test-package-and-gem.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
paths-ignore:
1010
- '**.md'
1111
- 'docs/**'
12+
- '.lychee.toml'
1213
- 'react_on_rails/lib/**'
1314
- 'react_on_rails/spec/**'
1415
- 'packages/react_on_rails/**'

0 commit comments

Comments
 (0)