Address PR #4080 review findings for the stable RSC pin (#3634)

- CHANGELOG: fix the changelog entry's PR link to point at PR 4080
  (was pointing at the issue URL /pull/3634); keep Closes Issue 3634.
- Generator messaging: make rsc_dependency_pin_info and
  rsc_dependency_pin_failed_warning conditional on whether
  RSC_PACKAGE_VERSION_PIN is a prerelease (contains "-"). A prerelease
  pin keeps the existing "temporarily / this prerelease / until stable
  {target} is published" wording; the now-stable 19.0.5 pin uses
  accurate wording with no prerelease/temporary framing. Add a stable-pin
  spec asserting the messages omit prerelease wording, and update the
  install_generator_spec expectation accordingly.
- Docs: reword the React-19.0.x NOTE in create-without-ssr.md and
  upgrading-existing-pro-app.md to state the generator pins
  react-on-rails-rsc to exactly 19.0.5 (no ^/~) and that manual
  installers should record it as exactly 19.0.5 because the RSC bundler
  APIs are version-coupled, while react/react-dom stay on ~19.0.4.
  Regenerate llms-full-pro.txt to mirror the doc edits.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: justin808

docs/pro/react-server-components/create-without-ssr.md

@@ -35,7 +35,7 @@ yarn add react@~19.0.4 react-dom@~19.0.4 react-on-rails-rsc@19.0.5
 > [!NOTE]
 > React on Rails Pro RSC currently supports React 19.0.x with patch >= 19.0.4. Do not upgrade generated RSC apps to React 19.1 or 19.2 just because those versions are newer on npm; the RSC bundler APIs used internally can change between React minor versions. See the [React documentation on Server Components](https://react.dev/reference/rsc/server-components#how-do-i-build-support-for-server-components) for details.
 >
-> The example above pins the stable `react-on-rails-rsc@19.0.5` release exactly, matching the generator default.
+> The generator pins `react-on-rails-rsc` to exactly `19.0.5` (no `^` or `~`), matching the generator default. Because the RSC bundler APIs are version-coupled, manual installers should record `react-on-rails-rsc` as exactly `19.0.5` in `package.json` rather than the default caret range; `react` and `react-dom` stay on `~19.0.4`.
 
 2. Enable support for Server Components in React on Rails Pro configuration:
 

docs/pro/react-server-components/upgrading-existing-pro-app.md

@@ -34,7 +34,7 @@ pnpm add react@~19.0.4 react-dom@~19.0.4 react-on-rails-rsc@19.0.5
 > The RSC generator intentionally stays on React 19.0.x and does not widen generated apps to React 19.1 or 19.2 yet. React's RSC runtime and bundler APIs can change between minor releases, so advance the React range only when the generator, docs, and package metadata policy are reviewed together.
 
 > [!NOTE]
-> `react-on-rails-rsc@19.0.5` is the exact stable pin used by the generator. This is separate from the Pro package peer metadata tracked in [issue #3609](https://github.com/shakacode/react_on_rails/issues/3609): metadata can allow RSC packages broadly enough for `npm ls`, while the generator still installs the tested exact RSC package pin.
+> The generator pins `react-on-rails-rsc` to exactly `19.0.5` (no `^` or `~`). Because the RSC bundler APIs are version-coupled, record `react-on-rails-rsc` as exactly `19.0.5` in `package.json` rather than the default caret range so a later `19.1.x`/`19.2.x` is not picked up; `react` and `react-dom` stay on `~19.0.4`. This is separate from the Pro package peer metadata tracked in [issue #3609](https://github.com/shakacode/react_on_rails/issues/3609): metadata can allow RSC packages broadly enough for `npm ls`, while the generator still installs the tested exact RSC package pin.
 
 ## Pre-Migration: Audit Components for Client API Usage
 

llms-full-pro.txt

@@ -6359,7 +6359,7 @@ yarn add react@~19.0.4 react-dom@~19.0.4 react-on-rails-rsc@19.0.5
 > [!NOTE]
 > React on Rails Pro RSC currently supports React 19.0.x with patch >= 19.0.4. Do not upgrade generated RSC apps to React 19.1 or 19.2 just because those versions are newer on npm; the RSC bundler APIs used internally can change between React minor versions. See the [React documentation on Server Components](https://react.dev/reference/rsc/server-components#how-do-i-build-support-for-server-components) for details.
 >
-> The example above pins the stable `react-on-rails-rsc@19.0.5` release exactly, matching the generator default.
+> The generator pins `react-on-rails-rsc` to exactly `19.0.5` (no `^` or `~`), matching the generator default. Because the RSC bundler APIs are version-coupled, manual installers should record `react-on-rails-rsc` as exactly `19.0.5` in `package.json` rather than the default caret range; `react` and `react-dom` stay on `~19.0.4`.
 
 2. Enable support for Server Components in React on Rails Pro configuration:
 
@@ -7951,7 +7951,7 @@ pnpm add react@~19.0.4 react-dom@~19.0.4 react-on-rails-rsc@19.0.5
 > The RSC generator intentionally stays on React 19.0.x and does not widen generated apps to React 19.1 or 19.2 yet. React's RSC runtime and bundler APIs can change between minor releases, so advance the React range only when the generator, docs, and package metadata policy are reviewed together.
 
 > [!NOTE]
-> `react-on-rails-rsc@19.0.5` is the exact stable pin used by the generator. This is separate from the Pro package peer metadata tracked in [issue #3609](https://github.com/shakacode/react_on_rails/issues/3609): metadata can allow RSC packages broadly enough for `npm ls`, while the generator still installs the tested exact RSC package pin.
+> The generator pins `react-on-rails-rsc` to exactly `19.0.5` (no `^` or `~`). Because the RSC bundler APIs are version-coupled, record `react-on-rails-rsc` as exactly `19.0.5` in `package.json` rather than the default caret range so a later `19.1.x`/`19.2.x` is not picked up; `react` and `react-dom` stay on `~19.0.4`. This is separate from the Pro package peer metadata tracked in [issue #3609](https://github.com/shakacode/react_on_rails/issues/3609): metadata can allow RSC packages broadly enough for `npm ls`, while the generator still installs the tested exact RSC package pin.
 
 ## Pre-Migration: Audit Components for Client API Usage
 

react_on_rails/lib/generators/react_on_rails/js_dependency_manager.rb

@@ -488,23 +488,42 @@ def rsc_stable_package_version_target
         RSC_PACKAGE_VERSION_PIN.split("-", 2).first
       end
 
+      def rsc_package_version_prerelease?
+        RSC_PACKAGE_VERSION_PIN.include?("-")
+      end
+
       def rsc_dependency_pin_info
-        "React Server Components package pin: all --rsc installs temporarily use " \
-          "react-on-rails-rsc@#{RSC_PACKAGE_VERSION_PIN}, including Webpack projects. " \
-          "This prerelease keeps react-on-rails-rsc/WebpackPlugin compatible while adding " \
-          "react-on-rails-rsc/RspackPlugin. Keep the pin until stable " \
-          "react-on-rails-rsc@#{rsc_stable_package_version_target} " \
-          "is published and tagged latest."
+        if rsc_package_version_prerelease?
+          "React Server Components package pin: all --rsc installs temporarily use " \
+            "react-on-rails-rsc@#{RSC_PACKAGE_VERSION_PIN}, including Webpack projects. " \
+            "This prerelease keeps react-on-rails-rsc/WebpackPlugin compatible while adding " \
+            "react-on-rails-rsc/RspackPlugin. Keep the pin until stable " \
+            "react-on-rails-rsc@#{rsc_stable_package_version_target} " \
+            "is published and tagged latest."
+        else
+          "React Server Components package pin: all --rsc installs use " \
+            "react-on-rails-rsc@#{RSC_PACKAGE_VERSION_PIN}, including Webpack projects. " \
+            "This pin keeps react-on-rails-rsc/WebpackPlugin compatible while adding " \
+            "react-on-rails-rsc/RspackPlugin."
+        end
       end
 
       def rsc_dependency_pin_failed_warning
-        "Warning: Could not install the pinned react-on-rails-rsc@#{RSC_PACKAGE_VERSION_PIN}. " \
-          "All RSC projects are temporarily pinned to that version: the prerelease keeps " \
-          "react-on-rails-rsc/WebpackPlugin compatible while adding react-on-rails-rsc/RspackPlugin, " \
-          "and the unversioned `latest` tag may not include both until stable " \
-          "#{rsc_stable_package_version_target} " \
-          "is published, so the generator left the version pin in package.json rather than " \
-          "install a potentially incompatible version."
+        if rsc_package_version_prerelease?
+          "Warning: Could not install the pinned react-on-rails-rsc@#{RSC_PACKAGE_VERSION_PIN}. " \
+            "All RSC projects are temporarily pinned to that version: the prerelease keeps " \
+            "react-on-rails-rsc/WebpackPlugin compatible while adding react-on-rails-rsc/RspackPlugin, " \
+            "and the unversioned `latest` tag may not include both until stable " \
+            "#{rsc_stable_package_version_target} " \
+            "is published, so the generator left the version pin in package.json rather than " \
+            "install a potentially incompatible version."
+        else
+          "Warning: Could not install the pinned react-on-rails-rsc@#{RSC_PACKAGE_VERSION_PIN}. " \
+            "All RSC projects are pinned to that version: this pin keeps " \
+            "react-on-rails-rsc/WebpackPlugin compatible while adding react-on-rails-rsc/RspackPlugin, " \
+            "so the generator left the version pin in package.json rather than " \
+            "install a potentially incompatible version."
+        end
       end
 
       def rsc_dependency_pin_failure_details(used_version_pins)

react_on_rails/spec/react_on_rails/generators/install_generator_spec.rb

@@ -2478,25 +2478,26 @@ class ActiveSupport::TestCase
   describe "#add_rsc_dependencies" do
     let(:install_generator) { described_class.new([], { rsc: true }, destination_root:) }
     let(:rsc_pin) { ReactOnRails::Generators::JsDependencyManager::RSC_PACKAGE_VERSION_PIN }
-    let(:rsc_stable_target) { install_generator.send(:rsc_stable_package_version_target) }
 
     before do
       GeneratorMessages.clear
       allow(install_generator).to receive(:say)
       allow(install_generator).to receive(:fallback_package_manager).and_return("pnpm")
     end
 
-    it "explains why every RSC install is temporarily pinned to the prerelease package" do
+    it "explains why every RSC install is pinned to the stable package" do
       allow(install_generator).to receive(:add_packages).and_return(true)
 
       install_generator.send(:add_rsc_dependencies)
 
       message_text = GeneratorMessages.messages.join("\n")
       expect(message_text).to include("all --rsc installs")
       expect(message_text).to include("react-on-rails-rsc@#{rsc_pin}")
-      expect(message_text).to include("stable react-on-rails-rsc@#{rsc_stable_target}")
       expect(message_text).to include("react-on-rails-rsc/RspackPlugin")
       expect(message_text).to include("Webpack")
+      expect(message_text).not_to include("prerelease")
+      expect(message_text).not_to include("temporarily")
+      expect(message_text).not_to include("until stable")
     end
 
     it "keeps the version pin and uses the detected package manager when manual RSC recovery is needed" do

react_on_rails/spec/react_on_rails/generators/js_dependency_manager_spec.rb

@@ -738,6 +738,22 @@ def errors
       expect(warning).to include("stable 19.1.0")
       expect(warning).not_to include("stable 19.0.5")
     end
+
+    it "uses accurate messaging without prerelease wording for a stable package pin" do
+      expect(ReactOnRails::Generators::JsDependencyManager::RSC_PACKAGE_VERSION_PIN).to eq("19.0.5")
+
+      info = instance.send(:rsc_dependency_pin_info)
+      warning = instance.send(:rsc_dependency_pin_failed_warning)
+
+      [info, warning].each do |message|
+        expect(message).to include("react-on-rails-rsc@19.0.5")
+        expect(message).to include("react-on-rails-rsc/WebpackPlugin")
+        expect(message).to include("react-on-rails-rsc/RspackPlugin")
+        expect(message).not_to include("prerelease")
+        expect(message).not_to include("temporarily")
+        expect(message).not_to include("until stable")
+      end
+    end
   end
 
   describe "#add_rsc_dependencies" do