Skip to content

Commit f8b8b17

Browse files
committed
ci: address benchmark workflow review
1 parent 03cfb1e commit f8b8b17

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ jobs:
349349
set -e # Exit on any error
350350
echo "🏃 Running Core benchmark suite..."
351351
352-
if ! $BENCH_CMD benchmarks/bench.rb; then
352+
if ! BASE_URL="localhost:${BENCHMARK_PORT}" $BENCH_CMD benchmarks/bench.rb; then
353353
echo "❌ ERROR: Benchmark execution failed"
354354
exit 1
355355
fi
@@ -473,7 +473,7 @@ jobs:
473473
set -e
474474
echo "🏃 Running Pro benchmark suite..."
475475
476-
if ! PRO=true $BENCH_CMD benchmarks/bench.rb; then
476+
if ! BASE_URL="localhost:${BENCHMARK_PORT}" PRO=true $BENCH_CMD benchmarks/bench.rb; then
477477
echo "❌ ERROR: Benchmark execution failed"
478478
exit 1
479479
fi

.github/workflows/integration-tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,7 @@ jobs:
121121
- uses: actions/checkout@v4
122122
with:
123123
persist-credentials: false
124-
# libyaml-dev is needed for psych v5
125-
# this gem depends on sdoc which depends on rdoc which depends on psych
124+
# libyaml-dev is needed for psych v5 native extensions (sdoc -> rdoc -> psych)
126125
- name: Install libyaml-dev (required for psych v5 native extensions)
127126
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libyaml-dev
128127
- name: Setup Ruby

0 commit comments

Comments
 (0)