Skip to content

Follow-up: Make priority review disposition evidence ledger-clean #4483

Description

@justin808

Summary

The post-merge audit for PR #4473 found that the P2 review thread was actually fixed and resolved, but script/pr-merge-ledger --strict still reports the priority finding disposition as UNKNOWN.

This is not a product defect in #4473. It is an evidence/tooling gap: the review reply clearly records Fixed in b734006cbff865e2bd08b33c5db47d83d69311f0 plus validation evidence, but the strict ledger does not recognize that as a fixed disposition.

Audit ledger: not applicable (focused post-merge batch audit, not a release-gate snapshot).

Replay

script/pr-merge-ledger 4473 \
  --repo shakacode/react_on_rails \
  --strict \
  --pretty \
  --changelog-classification not_user_visible

Current result:

Process Gap Disposition

  • Mechanism target: checklist+replay
  • Motivating miss: PR Match create-app color fallback to chalk #4473 fixed a P2 review thread, but post-merge strict ledger remained non-clean because the fixed disposition was not recognized.
  • Replay evidence: run the strict ledger command above against PR Match create-app color fallback to chalk #4473 and verify the disposition is recognized or the checklist tells the closer how to record it in the ledger-supported format.
  • Non-goal: do not add a broad prose-only rule that says "reply to review comments"; the mechanism should make ledger-clean disposition evidence replayable.

Acceptance Criteria

  • The Match create-app color fallback to chalk #4473 replay either passes strict ledger or documents the exact ledger-supported reply/disposition format needed for fixed P2 findings.
  • The closeout checklist or ledger parser is updated so future fixed P2/Must-Fix threads do not remain UNKNOWN after a clear fix reply and resolution.
  • The replay command above is captured in the issue or PR evidence for the fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions