-
-
Notifications
You must be signed in to change notification settings - Fork 629
feat: add REACT_ON_RAILS_BASE_PORT for concurrent worktree port management #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
5cdd939
feat: add REACT_ON_RAILS_BASE_PORT for concurrent worktree port manag…
justin808 a9f8bea
chore: add .gstack/ to .gitignore
justin808 001c19a
fix: address review feedback on base port feature
justin808 3675263
fix: second round of port selector review feedback
justin808 6589747
fix: third round of port selector review feedback
justin808 6cf3724
fix: fourth round of port selector review feedback
justin808 f430db1
fix: fifth round of port selector review feedback
justin808 889a150
fix: sixth round of port selector review feedback
justin808 c5a6f76
fix: seventh round of port selector review feedback
justin808 f2adcdb
fix: eighth round of port selector review feedback
justin808 e9418ec
fix: ninth round of port selector review feedback
justin808 c2b76ec
fix: keep renderer fallbacks aligned
justin808 5dd9456
fix: tenth round of port selector review feedback
justin808 268a2cc
fix: eleventh round of port selector review feedback
justin808 287d30e
fix: twelfth round of port selector review feedback
justin808 3f33b2e
Fix Pro generator expectations for renderer port env default
justin808 26ab092
fix: honor REACT_ON_RAILS_BASE_PORT in bin/dev prod mode
justin808 6a692b9
fix: thirteenth round of port selector review feedback
justin808 803970e
fix: accept IPv6 hosts in url_port_mismatch? regex
justin808 3535812
fix: six round-15 review fixes around base-port consistency
justin808 4434b44
fix: round 16 review fixes — 5 design/doc polish
justin808 e1c658a
fix: clean copied runtime files before bin/dev startup
justin808 7e56bd3
fix: round 17 review polish — 4 doc/UX fixes
justin808 d3cabf9
fix: round 18 review polish — 5 fixes from cursor + claude bots
justin808 5601be4
fix: round 19 review polish — 5 fixes from cursor + claude bots
justin808 7ca8054
fix: round 20 review polish — 5 fixes from claude bot
justin808 4e9504f
fix: round 21 review polish — case-insensitive localhost + whitespace…
justin808 4dce031
Merge main and address review blockers
justin808 53c62ee
Avoid killing OSS renderer-derived port
justin808 3d328f8
Harden dev cleanup review fixes
justin808 5ef6d50
Skip renderer kill fallback for remote URLs
justin808 db313f1
Cover local renderer URL port cleanup
justin808 a7d748a
Respect local renderer URL port during cleanup
justin808 b1cc0bb
fix: round 22 review polish — 16 fixes from claude/cursor/codex bots
justin808 ae374f7
Merge remote-tracking branch 'origin/main' into codex/pr-3142-work
justin808 31b63d1
fix: harden base-port review edge cases
justin808 98d221f
fix: round 23 review polish — 6 fixes from claude/codex bots
justin808 11877c6
fix: round 24 review polish — 8 fixes from claude[bot] review
justin808 2c67e07
fix: round 25 review polish — 8 fixes from claude/cursor bots
justin808 d90fcef
docs: revert container-deployment.md RENDERER_URL rename
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,3 +101,4 @@ packages/**/node_modules/ | |
| junit.xml | ||
| .lycheecache | ||
| .playwright-cli/ | ||
| .gstack/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.