-
-
Notifications
You must be signed in to change notification settings - Fork 635
feat: add REACT_ON_RAILS_BASE_PORT for concurrent worktree port management #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justin808
wants to merge
28
commits into
main
Choose a base branch
from
jg/concurrent-worktree-ports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4d5dcc5
feat: add REACT_ON_RAILS_BASE_PORT for concurrent worktree port manag…
justin808 78561e2
chore: add .gstack/ to .gitignore
justin808 0587a7e
fix: address review feedback on base port feature
justin808 47d0588
fix: second round of port selector review feedback
justin808 93d80d8
fix: third round of port selector review feedback
justin808 602ecdb
fix: fourth round of port selector review feedback
justin808 755dfe5
fix: fifth round of port selector review feedback
justin808 4d5ef21
fix: sixth round of port selector review feedback
justin808 12ecae2
fix: seventh round of port selector review feedback
justin808 592a422
fix: eighth round of port selector review feedback
justin808 1c3e3f1
fix: ninth round of port selector review feedback
justin808 57a4c31
fix: keep renderer fallbacks aligned
justin808 a13e792
fix: tenth round of port selector review feedback
justin808 99b50e3
fix: eleventh round of port selector review feedback
justin808 de13c1a
fix: twelfth round of port selector review feedback
justin808 4a7c434
Fix Pro generator expectations for renderer port env default
justin808 00c58af
fix: honor REACT_ON_RAILS_BASE_PORT in bin/dev prod mode
justin808 9617025
fix: thirteenth round of port selector review feedback
justin808 fd51626
fix: accept IPv6 hosts in url_port_mismatch? regex
justin808 d8dc1cc
fix: six round-15 review fixes around base-port consistency
justin808 61f0ad2
fix: round 16 review fixes — 5 design/doc polish
justin808 73b3fe0
fix: clean copied runtime files before bin/dev startup
justin808 f949a69
ci: ignore flaky GitHub PR link checks
justin808 0c9e2e1
fix: round 17 review polish — 4 doc/UX fixes
justin808 3997ea1
fix: round 18 review polish — 5 fixes from cursor + claude bots
justin808 4f2f0f0
fix: round 19 review polish — 5 fixes from cursor + claude bots
justin808 a3e4ccb
fix: round 20 review polish — 5 fixes from claude bot
justin808 a0af6ab
fix: round 21 review polish — case-insensitive localhost + whitespace…
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,3 +101,4 @@ packages/**/node_modules/ | |
| junit.xml | ||
| .lycheecache | ||
| .playwright-cli/ | ||
| .gstack/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.