test: enable RSpec --profile to surface slowest package tests#3176
test: enable RSpec --profile to surface slowest package tests#3176
Conversation
Uncomments config.profile_examples = 10 in spec_helper so each test run prints the 10 slowest examples, enabling data-driven optimization of the ~24 minute package test suite. Fixes #3132 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single RSpec configuration setting was uncommented in the test helper to enable performance profiling. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR uncomments a single line — Confidence Score: 5/5Safe to merge — single diagnostic config line with no impact on test correctness or CI outcomes. The only changed line enables RSpec's built-in profiling output; it cannot cause test failures and has no side effects on the test suite results themselves. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[bundle exec rspec] --> B[Run all specs]
B --> C{config.profile_examples = 10}
C -->|Enabled after this PR| D[Record per-example timing]
D --> E[Print normal pass/fail summary]
E --> F[Print Top 10 slowest examples]
F --> G[Print Top 10 slowest groups]
C -->|Was commented out before| H[Print normal pass/fail summary only]
Reviews (1): Last reviewed commit: "test: enable RSpec --profile to surface ..." | Re-trigger Greptile |
Review: Enable RSpec
|
…ons-docs * origin/main: chore: remove redundant --rsc-pro install generator flag (#3105) ci: warn (don't fail) on Bencher main regression (#3168) test: enable RSpec --profile to surface slowest package tests (#3176) fix(node-renderer): expose performance in VM context when supportModules (#3158) docs: remove stale immediate_hydration references (#3139) (#3159) docs: restore absolute URL for node-renderer testing example (#3179) Bump Rspack dependencies to v2 (^2.0.0-0) (#3084) chore: remove obsolete webpack <5.106.0 pin (#3175) Move Node Renderer entry point to renderer/ directory (#3165) docs: address RSC pitfalls review follow-ups (#3155) (#3156) docs: remove fabricated DevConsole reference, link verified RSC tools (#2527) (#3163) # Conflicts: # docs/oss/building-features/node-renderer/js-configuration.md
…ging' into jg/3122-rolling-deploy-adapter * origin/jg/3122-unify-renderer-cache-staging: (39 commits) fix(specs): boot dummy specs without readline and drop redundant pnpm workspace (#3190) docs: add RSC migration success stories page (#1985) (#3162) Fix Bencher reporting permanently broken on pushes to main (#3148) docs: add example migrations guide (#3126) docs: remove defunct guavapass.com reference (#3199) chore: remove redundant --rsc-pro install generator flag (#3105) ci: warn (don't fail) on Bencher main regression (#3168) test: enable RSpec --profile to surface slowest package tests (#3176) fix(node-renderer): expose performance in VM context when supportModules (#3158) docs: remove stale immediate_hydration references (#3139) (#3159) docs: restore absolute URL for node-renderer testing example (#3179) Bump Rspack dependencies to v2 (^2.0.0-0) (#3084) chore: remove obsolete webpack <5.106.0 pin (#3175) Move Node Renderer entry point to renderer/ directory (#3165) docs: address RSC pitfalls review follow-ups (#3155) (#3156) docs: remove fabricated DevConsole reference, link verified RSC tools (#2527) (#3163) Scaffold CI workflow and build scripts for first-run consistency (#3097) Add OPTIONAL triage tier and fix recommendations to /address-review (#3161) chore: sync Gemfile.lock with term-ansicolor 1.11.3 (#3164) Simplify the docs sidebar and Pro landing pages (#3119) ...
* origin/main: fix(specs): boot dummy specs without readline and drop redundant pnpm workspace (#3190) docs: add RSC migration success stories page (#1985) (#3162) Fix Bencher reporting permanently broken on pushes to main (#3148) docs: add example migrations guide (#3126) docs: remove defunct guavapass.com reference (#3199) chore: remove redundant --rsc-pro install generator flag (#3105) ci: warn (don't fail) on Bencher main regression (#3168) test: enable RSpec --profile to surface slowest package tests (#3176) fix(node-renderer): expose performance in VM context when supportModules (#3158) docs: remove stale immediate_hydration references (#3139) (#3159) docs: restore absolute URL for node-renderer testing example (#3179) Bump Rspack dependencies to v2 (^2.0.0-0) (#3084) chore: remove obsolete webpack <5.106.0 pin (#3175) Move Node Renderer entry point to renderer/ directory (#3165) docs: address RSC pitfalls review follow-ups (#3155) (#3156) # Conflicts: # CHANGELOG.md
Summary
config.profile_examples = 10inreact_on_rails/spec/react_on_rails/spec_helper.rbso each run prints the 10 slowest examples.before(:all)blocks, etc.Fixes #3132
Test plan
bundle exec rubocop react_on_rails/spec/react_on_rails/spec_helper.rb— no offensesutils_spec.rb) locally; confirmed "Top 10 slowest examples" block appears at the end of the run🤖 Generated with Claude Code
Note
Low Risk
Low risk: test-only configuration change that only affects RSpec output and adds minor runtime overhead from collecting timings.
Overview
Enables RSpec profiling in
react_on_rails/spec/react_on_rails/spec_helper.rbby turning onconfig.profile_examples = 10, so each spec run reports the 10 slowest examples/example groups to help target test-suite performance work.Reviewed by Cursor Bugbot for commit 82417ab. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit