Migrate OSS dummy client examples to TypeScript #3606
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ import type { | |
| RendererFunction, | ||
| RendererTeardown, | ||
| RenderReturnType, | ||
| RegisteredComponentValue, | ||
| } from './types/index.ts'; | ||
| import ComponentRegistry from './ComponentRegistry.ts'; | ||
| import StoreRegistry from './StoreRegistry.ts'; | ||
|
|
@@ -19,6 +20,7 @@ import { isRendererTeardownResult } from './rendererTeardown.ts'; | |
| const REACT_ON_RAILS_STORE_ATTRIBUTE = 'data-js-react-on-rails-store'; | ||
|
|
||
| type RendererResult = ReturnType<RendererFunction>; | ||
| type RegisteredComponentEntry = RegisteredComponent<RegisteredComponentValue>; | ||
|
|
||
| // An entry in `renderedRoots`. We track two kinds of mounts so both can be cleaned up on page | ||
| // unload or same-id node replacement: | ||
|
|
@@ -110,7 +112,7 @@ function domNodeIdForEl(el: Element): string { | |
| type DelegationResult = { delegated: false } | { delegated: true; result: RendererResult }; | ||
|
|
||
| function delegateToRenderer( | ||
| componentObj: RegisteredComponentEntry, | ||
| props: Record<string, unknown>, | ||
| railsContext: RailsContext, | ||
| domNodeId: string, | ||
|
|
@@ -133,6 +135,10 @@ DELEGATING TO RENDERER ${name} for dom node with id: ${domNodeId} with props, ra | |
| // component union, so `as RendererFunction` is a runtime-invariant assertion guarded by | ||
| // `isRenderer` (the registry only sets it for a 3-arg render function), not a structural | ||
| // narrowing. | ||
| if (typeof component !== 'function') { | ||
| throw new Error(`Registered renderer "${name}" must be a function.`); | ||
| } | ||
|
|
||
| const result = (component as RendererFunction)(props, railsContext, domNodeId); | ||
| return { delegated: true, result }; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,15 @@ | ||
| import type { RegisteredComponent, RegisteredComponentValue } from './types/index.ts'; | ||
| import isRenderFunction from './isRenderFunction.ts'; | ||
|
|
||
| type RegisteredComponentEntry = RegisteredComponent<RegisteredComponentValue>; | ||
|
|
||
| const registeredComponents = new Map<string, RegisteredComponentEntry>(); | ||
|
|
||
| export default { | ||
| /** | ||
| * @param components { component1: component1, component2: component2, etc. } | ||
| */ | ||
| register(components: Record<string, RegisteredComponentValue>): void { | ||
| Object.keys(components).forEach((name) => { | ||
| const component = components[name]; | ||
| if (!component) { | ||
|
|
@@ -40,7 +42,7 @@ export default { | |
| * @param name | ||
| * @returns { name, component, renderFunction, isRenderer } | ||
| */ | ||
| get(name: string): RegisteredComponentEntry { | ||
| const registeredComponent = registeredComponents.get(name); | ||
| if (registeredComponent !== undefined) { | ||
| return registeredComponent; | ||
|
|
@@ -56,7 +58,7 @@ Registered component names include [ ${keys} ]. Maybe you forgot to register the | |
| * @returns Map where key is the component name and values are the | ||
| * { name, component, renderFunction, isRenderer} | ||
| */ | ||
| components(): Map<string, RegisteredComponentEntry> { | ||
| return registeredComponents; | ||
| }, | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.